Sign upLogin

FelixMcFelix/webrtc-conductor

View on GitHub
Star

Showing 8 of 13 total issues

Function WebRTCResourceManager has a Cognitive Complexity of 92 (exceeds 5 allowed). Consider refactoring.
Open

function WebRTCResourceManager(config){
    this._channelRegistry = {};
    this._connectionRegistry = {};

    let _lookupChannel = id => {
Severity: Minor
Found in src/wrtc-res-man.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WebRTCResourceManager has 254 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function WebRTCResourceManager(config){
    this._channelRegistry = {};
    this._connectionRegistry = {};

    let _lookupChannel = id => {
Severity: Major
Found in src/wrtc-res-man.js - About 1 day to fix

    File wrtc-res-man.js has 337 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";

const wrtc_adapter = require("webrtc-adapter-test")
    , enums = {
        RESPONSE_NONE: Symbol("Miscellaneous Response"),
    Severity: Minor
    Found in src/wrtc-res-man.js - About 4 hrs to fix

      Function connectTo has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.connectTo = (id, channel) => {
        // Return an instance of a given connection by its id.
        // This increments a connection's usage counter.
        // If the channel supplied is an id, look it up in the registry.
        //        If it has been bound to this, use it. If bound to another manager, throw.
      Severity: Major
      Found in src/wrtc-res-man.js - About 2 hrs to fix

        Function TrackedConnection has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function TrackedConnection(id, rtcConn){
    // let _usages = 0;

    // Object.defineProperty(this, {
    //     "usages": {
        Severity: Major
        Found in src/wrtc-res-man.js - About 2 hrs to fix

          Function response has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.response = (msg, channel) => {
        // Call this function to to pass a response from a channel to the correct channel handler.
        // channel may either be a channel object or an id - in both cases the channel object MUST
        // be registered to the controller.
        channel = _channelFromObjectOrId(channel);
          Severity: Minor
          Found in src/wrtc-res-man.js - About 1 hr to fix

            Function TrackedConnection has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            function TrackedConnection(id, rtcConn){
    // let _usages = 0;

    // Object.defineProperty(this, {
    //     "usages": {
            Severity: Minor
            Found in src/wrtc-res-man.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _newConnection has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _newConnection = (id, channel, response) => {
        let conn = new this.config.rtc_facade.RTCPeerConnection(this.config.rtc_config),
            trConn = new TrackedConnection(id, conn),
            t = this;
            Severity: Minor
            Found in src/wrtc-res-man.js - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language