Sign upLogin

Firesphere/silverstripe-csp-headers

View on GitHub
Star
src/Models/CSPDomain.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Method providePermissions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function providePermissions()
    {
        return [
            'CREATE_CSPDOMAIN' => [
                'name'     => _t(self::class . '.PERMISSION_CREATE_DESCRIPTION', 'Create CSP Domains'),
Severity: Minor
Found in src/Models/CSPDomain.php - About 1 hr to fix

    Avoid unused private fields such as '$db'.
    Open

        private static $db = [
        'Domain' => DBVarchar::class,
        'Source' => DBEnum::class . '("default,script,style,img,media,font,form,frame,ancestor,worker,connect")'
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$searchable_fields'.
    Open

        private static $searchable_fields = [
        'Domain',
        'Source'
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused local variables such as '$key'.
    Open

            foreach ($map as $key => &$value) {
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused private fields such as '$indexes'.
    Open

        private static $indexes = [
        'Domain' => true
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$singular_name'.
    Open

        private static $singular_name = 'Content Security Policy Domain';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$summary_fields'.
    Open

        private static $summary_fields = [
        'Domain',
        'Source'
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$table_name'.
    Open

        private static $table_name = 'CSPDomain';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$plural_name'.
    Open

        private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused private fields such as '$belongs_many_many'.
    Open

        private static $belongs_many_many = [
        'Pages' => Page::class
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid using static access to class '\SilverStripe\Security\Permission' in method 'canView'.
    Open

                return Permission::check('VIEW_CSPDomain', 'any', $member);
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\SilverStripe\Security\Permission' in method 'canCreate'.
    Open

                return Permission::check('CREATE_CSPDomain', 'any', $member);
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\SilverStripe\Security\Permission' in method 'canEdit'.
    Open

                return Permission::check('EDIT_CSPDomain', 'any', $member);
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\SilverStripe\Security\Permission' in method 'canDelete'.
    Open

                return Permission::check('DELETE_CSPDOMAIN', 'any', $member);
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The property $singular_name is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The property $belongs_many_many is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The property $plural_name is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

        private static $db = [
        'Domain' => DBVarchar::class,
        'Source' => DBEnum::class . '("default,script,style,img,media,font,form,frame,ancestor,worker,connect")'
    ];
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The property $summary_fields is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The property $table_name is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The property $searchable_fields is not named in camelCase.
    Invalid

    class CSPDomain extends DataObject implements PermissionProvider
{
    private static $singular_name = 'Content Security Policy Domain';
    private static $plural_name = 'Content Security Policy Domains';
    Severity: Minor
    Found in src/Models/CSPDomain.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    There are no issues that match your filters.

    Category
    Status