Avoid using static access to class 'TextField' in method 'updateCMSFields'. Open
TextField::create('Viewid', 'View ID from Analytics'),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'DropdownField' in method 'updateCMSFields'. Open
DropdownField::create('DateRange', 'Amount of days to get', static::$date_range),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'DropdownField' in method 'updateCMSFields'. Open
DropdownField::create('Metric', 'Metrics', static::$metrics)- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused private fields such as '$db'. Open
private static $db = [
'Viewid' => 'Varchar(50)',
'DateRange' => 'Enum("7,30,60,90")',
'Metric' => 'Enum("ga:pageviews")'
];- Read upRead up
- Exclude checks
UnusedPrivateField
Since: 0.2
Detects when a private field is declared and/or assigned a value, but not used.
Example
class Something
{
private static $FOO = 2; // Unused
private $i = 5; // Unused
private $j = 6;
public function addOne()
{
return $this->j++;
}
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield
Avoid variables with short names like $db. Configured minimum length is 3. Open
private static $db = [
'Viewid' => 'Varchar(50)',
'DateRange' => 'Enum("7,30,60,90")',
'Metric' => 'Enum("ga:pageviews")'
];- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The property $date_range is not named in camelCase. Open
class GoogleAPISiteConfigExtension extends DataExtension
{
private static $db = [
'Viewid' => 'Varchar(50)',
'DateRange' => 'Enum("7,30,60,90")',- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}