Sign upLogin

Firesphere/silverstripe-google-api

View on GitHub
Star
code/Tasks/AnalyticsUpdateTask.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '34', column '24').
Open

        $service = new GoogleAnalyticsReportService($client);
Severity: Minor
Found in code/Tasks/AnalyticsUpdateTask.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '39', column '30').
Open

        $updateService = new PageUpdateService();
Severity: Minor
Found in code/Tasks/AnalyticsUpdateTask.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '21', column '30').
Open

        $clientService = new GoogleClientService();
Severity: Minor
Found in code/Tasks/AnalyticsUpdateTask.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$request'.
Invalid

    public function run($request)
Severity: Minor
Found in code/Tasks/AnalyticsUpdateTask.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status