Sign upLogin

Firesphere/silverstripe-haveibeenpwnd

View on GitHub
Star
src/services/HaveIBeenPwnedService.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused private fields such as '$save_pwnd'.
Open

    private static $save_pwnd = true;
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$allow_pwnd'.
Open

    private static $allow_pwnd = false;
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid using static access to class '\SilverStripe\Core\Convert' in method 'checkBreaches'.
Open

        $breaches = Convert::json2array($body);
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Remove this unused "$allow_pwnd" private field.
Invalid

    private static $allow_pwnd = false;
Severity: Major
Found in src/services/HaveIBeenPwnedService.php by sonar-php

If a private field is declared but not used in the program, it can be considered dead code and should therefore be removed. This will improve maintainability because developers will not wonder what the variable is used for.

Noncompliant Code Example

class MyClass {
  private $foo = 4;                       //foo is unused

  public function compute($a) {
    return $a * 4;
  }
}

Compliant Solution

class MyClass {

  public function compute($a) {
    return $a * 4;
  }
}

See

Remove this unused "$save_pwnd" private field.
Invalid

    private static $save_pwnd = true;
Severity: Major
Found in src/services/HaveIBeenPwnedService.php by sonar-php

If a private field is declared but not used in the program, it can be considered dead code and should therefore be removed. This will improve maintainability because developers will not wonder what the variable is used for.

Noncompliant Code Example

class MyClass {
  private $foo = 4;                       //foo is unused

  public function compute($a) {
    return $a * 4;
  }
}

Compliant Solution

class MyClass {

  public function compute($a) {
    return $a * 4;
  }
}

See

The property $allow_pwnd is not named in camelCase.
Open

class HaveIBeenPwnedService
{
    use Configurable;

    /**
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $save_pwnd is not named in camelCase.
Open

class HaveIBeenPwnedService
{
    use Configurable;

    /**
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The variable $api_key is not named in camelCase.
Open

    public function checkPwnedEmail($member)
    {
        $this->args['base_uri'] = static::PWND_URL;
        $api_key = $this->hibp_api_key;
        $uniqueField = Member::config()->get('unique_identifier_field');
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $api_key is not named in camelCase.
Open

    public function checkPwnedEmail($member)
    {
        $this->args['base_uri'] = static::PWND_URL;
        $api_key = $this->hibp_api_key;
        $uniqueField = Member::config()->get('unique_identifier_field');
Severity: Minor
Found in src/services/HaveIBeenPwnedService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status