Sign upLogin

Firesphere/silverstripe-solr-search

View on GitHub
Star
src/Models/SearchSynonym.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid unused private fields such as '$db'.
Open

    private static $db = [
        'Keyword' => 'Varchar(255)',
        'Synonym' => 'Text'
    ];
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$table_name'.
Open

    private static $table_name = 'Solr_SearchSynonym';
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$singular_name'.
Open

    private static $singular_name = 'Search synonym';
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$plural_name'.
Open

    private static $plural_name = 'Search synonyms';
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$summary_fields'.
Open

    private static $summary_fields = [
        'Keyword',
        'Synonym'
    ];
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid variables with short names like $db. Configured minimum length is 3.
Invalid

    private static $db = [
        'Keyword' => 'Varchar(255)',
        'Synonym' => 'Text'
    ];
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $singular_name is not named in camelCase.
Invalid

class SearchSynonym extends DataObject
{
    /**
     * @var string Table name
     */
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $summary_fields is not named in camelCase.
Invalid

class SearchSynonym extends DataObject
{
    /**
     * @var string Table name
     */
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $table_name is not named in camelCase.
Invalid

class SearchSynonym extends DataObject
{
    /**
     * @var string Table name
     */
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $plural_name is not named in camelCase.
Invalid

class SearchSynonym extends DataObject
{
    /**
     * @var string Table name
     */
Severity: Minor
Found in src/Models/SearchSynonym.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status