Sign upLogin

Fitbit/webpack-config

View on GitHub
Star

Showing 8 of 8 total issues

Function setUp has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setUp() {
        const container = this.container;

        container.bindValue(ConfigContainer, this);
        container.bindClass(ConfigPatternCache, ConfigPatternCache, Transient.with([]));
Severity: Minor
Found in test/MockConfigContainer.js - About 1 hr to fix

    Function setUp has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setUp() {
        const container = this.container;

        container.bindValue(ConfigContainer, this);
        container.bindValue(ConfigEnvironment, new ConfigEnvironment(Object.entries(process.env)));
    Severity: Minor
    Found in src/ConfigContainer.js - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          describe('patternCache', () => {
        it('should be instance of `ConfigPatternCache`', () => {
            expect(patternCache).toEqual(jasmine.any(ConfigPatternCache));
        });
    });
      Severity: Major
      Found in test/index.spec.js and 3 other locations - About 40 mins to fix
      test/index.spec.js on lines 20..24
      test/index.spec.js on lines 33..37
      test/index.spec.js on lines 39..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          describe('Config', () => {
        it('should be defined', () => {
            expect(ConfigProxy).toEqual(jasmine.any(Function));
        });
    });
      Severity: Major
      Found in test/index.spec.js and 3 other locations - About 40 mins to fix
      test/index.spec.js on lines 33..37
      test/index.spec.js on lines 39..43
      test/index.spec.js on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          describe('cache', () => {
        it('should be instance of `ConfigCache`', () => {
            expect(cache).toEqual(jasmine.any(ConfigCache));
        });
    });
      Severity: Major
      Found in test/index.spec.js and 3 other locations - About 40 mins to fix
      test/index.spec.js on lines 20..24
      test/index.spec.js on lines 33..37
      test/index.spec.js on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          describe('environment', () => {
        it('should be instance of `ConfigEnvironment`', () => {
            expect(environment).toEqual(jasmine.any(ConfigEnvironment));
        });
    });
      Severity: Major
      Found in test/index.spec.js and 3 other locations - About 40 mins to fix
      test/index.spec.js on lines 20..24
      test/index.spec.js on lines 39..43
      test/index.spec.js on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function resolve has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          resolve(value, predicate) {
        for (const resolver of this.resolvers) {
            try {
                const resolvedValue = resolver(value),
                    throwsError = isError(resolvedValue) || resolvedValue instanceof Error;
      Severity: Minor
      Found in src/ConfigStrategyList.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          static normalizeOptions(options) {
        let normalizedOptions = [];

        if (isString(options)) {
            normalizedOptions = [{
      Severity: Minor
      Found in src/ConfigExtendCommand.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language