Sign upLogin

FitnessKeeper/leeroy

View on GitHub
Star
lib/leeroy/helpers/aws.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Module has too many lines. [329/250]
Open

    module AWS
      include Leeroy::Helpers

      attr :ec2, :rds, :s3
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks if the length a module exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

File aws.rb has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'aws-sdk'
require 'base64'

require 'leeroy/helpers'
require 'leeroy/helpers/env'
Severity: Minor
Found in lib/leeroy/helpers/aws.rb - About 4 hrs to fix

    Method filterImages has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/helpers/aws.rb - About 45 mins to fix

      Method createTags has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def createTags(tags = {}, resourceids = [], state = self.state, env = self.env, options = self.options)
      Severity: Minor
      Found in lib/leeroy/helpers/aws.rb - About 35 mins to fix

        Avoid parameter lists longer than 5 parameters. [6/5]
        Open

              def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        FIXME found
        Open

                  # FIXME i should do this with URI
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by fixme

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  if vpcs.length < 1
            raise "No VPC found with the name '#{vpcname}'."
          elsif vpcs.length > 1
            raise "Multiple VPCs found with the name '#{vpcname}'."
          else
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb and 2 other locations - About 25 mins to fix
        lib/leeroy/helpers/aws.rb on lines 110..116
        lib/leeroy/helpers/aws.rb on lines 138..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  if security_group.length < 1
            raise "No SG found with the name '#{sgname}'."
          elsif security_group.length > 1
            raise "Multiple SGs found with the name '#{sgname}'."
          else
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb and 2 other locations - About 25 mins to fix
        lib/leeroy/helpers/aws.rb on lines 78..84
        lib/leeroy/helpers/aws.rb on lines 138..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  if subnets.length < 1
            raise "No Subnet found with the name '#{subnetname}'."
          elsif subnets.length > 1
            raise "Multiple Subnets found with the name '#{subnetname}'."
          else
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb and 2 other locations - About 25 mins to fix
        lib/leeroy/helpers/aws.rb on lines 78..84
        lib/leeroy/helpers/aws.rb on lines 110..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Redundant use of Object#to_s in interpolation.
        Open

                  "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for string conversion in string interpolation, which is redundant.

        Example:

        # bad

"result is #{something.to_s}"

        Example:

        # good

"result is #{something}"

        Useless assignment to variable - resp.
        Open

                  resp = s3Request(:put_object, run_params)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
        Open

              def destroyInstance(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - resp.
        Open

                  resp = ec2Request(:create_tags, run_params)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
        Open

              def destroyInstance(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Redundant use of Object#to_s in interpolation.
        Open

                  "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for string conversion in string interpolation, which is redundant.

        Example:

        # bad

"result is #{something.to_s}"

        Example:

        # good

"result is #{something}"

        Unused method argument - state. If it's necessary, use _ or _state as an argument name to indicate that it won't be used.
        Open

              def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
        Open

              def getSubnetId(subnetname, vpcid, ec2 = self.ec2)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - e.
        Open

                rescue Aws::S3::Errors::NotFound => e
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
        Open

              def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - resp.
        Open

                    resp = s3Request(:delete_object, run_params)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Redundant use of Object#to_s in interpolation.
        Open

                  "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for string conversion in string interpolation, which is redundant.

        Example:

        # bad

"result is #{something.to_s}"

        Example:

        # good

"result is #{something}"

        Redundant use of Object#to_s in interpolation.
        Open

                  "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for string conversion in string interpolation, which is redundant.

        Example:

        # bad

"result is #{something.to_s}"

        Example:

        # good

"result is #{something}"

        Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
        Open

              def createTags(tags = {}, resourceids = [], state = self.state, env = self.env, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - e.
        Open

                rescue Aws::S3::Errors::NotFound => e
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
        Open

              def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Useless assignment to variable - resp.
        Open

                  resp = checkSemaphore(semaphore)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

        assigned but unused variable - foo

        Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

        Example:

        # bad

def some_method
  some_var = 1
  do_something
end

        Example:

        # good

def some_method
  some_var = 1
  do_something(some_var)
end

        Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
        Open

              def createTags(tags = {}, resourceids = [], state = self.state, env = self.env, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
        Open

              def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        Severity: Minor
        Found in lib/leeroy/helpers/aws.rb by rubocop

        This cop checks for unused method arguments.

        Example:

        # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

        Example:

        # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

        There are no issues that match your filters.

        Category
        Status