Sign upLogin

FitnessKeeper/leeroy

View on GitHub
Star
lib/leeroy/task/image.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method _genImageParams has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def _genImageParams(phase, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/image.rb - About 35 mins to fix

    Method _prepImageCreationPolling has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def _prepImageCreationPolling
        # poll to make sure image is created
        self.poll_callback = lambda do |imageid|
          begin
            run_params = { :image_ids => [imageid], :owners => ['self'] }
    Severity: Minor
    Found in lib/leeroy/task/image.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Useless assignment to variable - e.
    Open

              rescue Aws::EC2::Errors::InvalidAMIIDNotFound => e
    Severity: Minor
    Found in lib/leeroy/task/image.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
    Open

          def _genImageParams(phase, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/image.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
    Open

          def _genImageParams(phase, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/image.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    There are no issues that match your filters.

    Category
    Status