FitnessKeeper/leeroy

View on GitHub
lib/leeroy/task/instantiate.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method has too many lines. [34/30]
Open

      def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        begin
          logger.debug "generating params for creating an EC2 instance"

          # gather the necessary parameters
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for _genInstanceParams is too high. [7/6]
Open

      def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        begin
          logger.debug "generating params for creating an EC2 instance"

          # gather the necessary parameters
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method _genInstanceParams has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
        begin
          logger.debug "generating params for creating an EC2 instance"

          # gather the necessary parameters
Severity: Minor
Found in lib/leeroy/task/instantiate.rb - About 1 hr to fix

    Method _resolveResources has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
            begin
              # resolve VPC ID
              if state.vpcid?
                vpcid = state.vpcid
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _genInstanceParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
            begin
              logger.debug "generating params for creating an EC2 instance"
    
              # gather the necessary parameters
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
    Open

          def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    Useless assignment to variable - resp.
    Open

                resp = ec2Request(:describe_instances, run_params)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    end at 169, 10 is not aligned with case at 162, 21.
    Open

              end
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Useless assignment to variable - sgid.
    Open

                sgid = state.sgid
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
    Open

          def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    Useless assignment to variable - e.
    Open

              rescue Aws::EC2::Errors::InvalidInstanceIDNotFound => e
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
    Open

          def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
    Open

          def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    Useless assignment to variable - subnetid.
    Open

                subnetid = state.subnetid
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
    Open

          def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/instantiate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad
    
    def some_method(used, unused, _unused_but_allowed)
      puts used
    end

    Example:

    # good
    
    def some_method(used, _unused, _unused_but_allowed)
      puts used
    end

    There are no issues that match your filters.

    Category
    Status