Sign upLogin

FitnessKeeper/leeroy

View on GitHub
Star
lib/leeroy/task/packer.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method has too many lines. [37/30]
Open

      def _getPackerParams(state = self.state, env = self.env, options = self.options)
        begin
          logger.debug "generating Packer params to create an AMI"
          packer_params = Leeroy::Types::Mash.new
Severity: Minor
Found in lib/leeroy/task/packer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for _getPackerParams is too high. [10/6]
Open

      def _getPackerParams(state = self.state, env = self.env, options = self.options)
        begin
          logger.debug "generating Packer params to create an AMI"
          packer_params = Leeroy::Types::Mash.new
Severity: Minor
Found in lib/leeroy/task/packer.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method _getPackerParams has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def _getPackerParams(state = self.state, env = self.env, options = self.options)
        begin
          logger.debug "generating Packer params to create an AMI"
          packer_params = Leeroy::Types::Mash.new
Severity: Minor
Found in lib/leeroy/task/packer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _getPackerParams has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def _getPackerParams(state = self.state, env = self.env, options = self.options)
        begin
          logger.debug "generating Packer params to create an AMI"
          packer_params = Leeroy::Types::Mash.new
Severity: Minor
Found in lib/leeroy/task/packer.rb - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              if self.state.imageid?
            imageid = self.state.imageid
          elsif options[:imageid].nil?
            imageid = checkEnv('LEEROY_AWS_LINUX_AMI')
          else
    Severity: Minor
    Found in lib/leeroy/task/packer.rb and 2 other locations - About 15 mins to fix
    lib/leeroy/task/packer.rb on lines 75..81
    lib/leeroy/task/packer.rb on lines 92..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              if self.state.packer_template_prefix?
            packer_template_prefix = self.state.packer_template_prefix
          elsif options[:packer_template_prefix].nil?
            packer_template_prefix = checkEnv('LEEROY_PACKER_TEMPLATE_PREFIX')
          else
    Severity: Minor
    Found in lib/leeroy/task/packer.rb and 2 other locations - About 15 mins to fix
    lib/leeroy/task/packer.rb on lines 66..72
    lib/leeroy/task/packer.rb on lines 75..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              if self.state.app_name?
            app_name = self.state.app_name
          elsif options[:name].nil?
            app_name = checkEnv('LEEROY_APP_NAME')
          else
    Severity: Minor
    Found in lib/leeroy/task/packer.rb and 2 other locations - About 15 mins to fix
    lib/leeroy/task/packer.rb on lines 66..72
    lib/leeroy/task/packer.rb on lines 92..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 20.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Useless assignment to variable - validation.
    Open

              validation = validatePacker(cwd, { :vars => packer_vars })
    Severity: Minor
    Found in lib/leeroy/task/packer.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
    Open

          def _getPackerParams(state = self.state, env = self.env, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/packer.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    Unused method argument - state. If it's necessary, use _ or _state as an argument name to indicate that it won't be used.
    Open

          def _getPackerParams(state = self.state, env = self.env, options = self.options)
    Severity: Minor
    Found in lib/leeroy/task/packer.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    There are no issues that match your filters.

    Category
    Status