Sign upLogin

Fivell/active_admin_import

View on GitHub
Star

Showing 5 of 5 total issues

Method active_admin_import has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def active_admin_import(options = {}, &block)
      options.assert_valid_keys(*Options::VALID_OPTIONS)

      options = Options.options_for(config, options)
Severity: Minor
Found in lib/active_admin_import/dsl.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Model has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Model
    include ActiveModel::Model
    include ActiveModel::Validations
    include ActiveModel::Validations::Callbacks
Severity: Minor
Found in lib/active_admin_import/model.rb - About 2 hrs to fix

    Method active_admin_import has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def active_admin_import(options = {}, &block)
      options.assert_valid_keys(*Options::VALID_OPTIONS)

      options = Options.options_for(config, options)
    Severity: Major
    Found in lib/active_admin_import/dsl.rb - About 2 hrs to fix

      Method process_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def process_file
      lines = []
      batch_size = options[:batch_size].to_i
      File.open(file.path) do |f|
        # capture headers if not exist
      Severity: Minor
      Found in lib/active_admin_import/importer.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method batch_slice_columns has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def batch_slice_columns(slice_columns)
      # Only set @use_indexes for the first batch so that @use_indexes are in correct
      # position for subsequent batches
      unless defined?(@use_indexes)
        @use_indexes = []
      Severity: Minor
      Found in lib/active_admin_import/importer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language