Sign upLogin

Flak15/project-lvl2-s475

View on GitHub
Star

Showing 9 of 9 total issues

Function genDifferenceAst has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const genDifferenceAst = (firstDataObject, secondDataObject) => {
  const mergedKeys = _.union(_.keys(firstDataObject), _.keys(secondDataObject));

  const nodeGenerator = {
    nested(key, initialValue, finalValue) {
Severity: Major
Found in src/genDiffAst.js - About 2 hrs to fix

    Function genDifferenceAst has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    const genDifferenceAst = (firstDataObject, secondDataObject) => {
  const mergedKeys = _.union(_.keys(firstDataObject), _.keys(secondDataObject));

  const nodeGenerator = {
    nested(key, initialValue, finalValue) {
    Severity: Minor
    Found in src/genDiffAst.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('JSON format test', () => {
  const jsonFormatResult = getResultStringFromFile('jsonFormatResult');
  expect(genDiff(getFullFilePath('firstDeepJson.json'), getFullFilePath('secondDeepJson.json'), 'json')).toBe(jsonFormatResult);
});
    Severity: Minor
    Found in __tests__/gendiff.test.js and 1 other location - About 55 mins to fix
    __tests__/gendiff.test.js on lines 26..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('Plain format test', () => {
  const plainFormatResult = getResultStringFromFile('plainFormatResult');
  expect(genDiff(getFullFilePath('firstDeepJson.json'), getFullFilePath('secondDeepJson.json'), 'plain')).toBe(plainFormatResult);
});
    Severity: Minor
    Found in __tests__/gendiff.test.js and 1 other location - About 55 mins to fix
    __tests__/gendiff.test.js on lines 30..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('INI test', () => {
  const result = getResultStringFromFile('result');
  expect(genDiff(getFullFilePath('firstINI.ini'), getFullFilePath('secondINI.ini'))).toBe(result);
});
    Severity: Major
    Found in __tests__/gendiff.test.js and 3 other locations - About 50 mins to fix
    __tests__/gendiff.test.js on lines 10..13
    __tests__/gendiff.test.js on lines 14..17
    __tests__/gendiff.test.js on lines 22..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('Deep differense JSON test', () => {
  const deepDiffResult = getResultStringFromFile('deepResult');
  expect(genDiff(getFullFilePath('firstDeepJson.json'), getFullFilePath('secondDeepJson.json'))).toBe(deepDiffResult);
});
    Severity: Major
    Found in __tests__/gendiff.test.js and 3 other locations - About 50 mins to fix
    __tests__/gendiff.test.js on lines 10..13
    __tests__/gendiff.test.js on lines 14..17
    __tests__/gendiff.test.js on lines 18..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('YAML test', () => {
  const result = getResultStringFromFile('result');
  expect(genDiff(getFullFilePath('firstYAML.yml'), getFullFilePath('secondYAML.yaml'))).toBe(result);
});
    Severity: Major
    Found in __tests__/gendiff.test.js and 3 other locations - About 50 mins to fix
    __tests__/gendiff.test.js on lines 10..13
    __tests__/gendiff.test.js on lines 18..21
    __tests__/gendiff.test.js on lines 22..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('JSON test', () => {
  const result = getResultStringFromFile('result');
  expect(genDiff(getFullFilePath('firstConf.json'), getFullFilePath('secondConf.json'))).toBe(result);
});
    Severity: Major
    Found in __tests__/gendiff.test.js and 3 other locations - About 50 mins to fix
    __tests__/gendiff.test.js on lines 14..17
    __tests__/gendiff.test.js on lines 18..21
    __tests__/gendiff.test.js on lines 22..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return nodeGenerator.changed(key, initialValue, finalValue);
    Severity: Major
    Found in src/genDiffAst.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language