Flamov/steamchat-website

View on GitHub

Showing 16 of 20 total issues

Function yearsBehaviour has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

function yearsBehaviour() {
    const totalLength = $archives.$sidebar.$years.length;
    let yearsActive = 0;
    for (let i = 0; i < $archives.$sidebar.$years.length; i++) {
        if ($archives.$sidebar.$years[i].checked === true) {
Severity: Minor
Found in resources/assets/js/modules/archive.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function init(element) {
    // Cache element selectors
    $archives = element;
        $archives.$sidebar = $archives.getElementsByClassName('js-sidebar')[0];
            $archives.$sidebar.$search = $archives.$sidebar.getElementsByClassName('js-search')[0];
Severity: Minor
Found in resources/assets/js/modules/archive.js - About 1 hr to fix

    Function updateFilteringDisplay has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function updateFilteringDisplay() {
        const total = $archives.$episodes.length;
        let hiding = 0;
    
        const filterClasses = [
    Severity: Minor
    Found in resources/assets/js/modules/archive.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateFilteringDisplay has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateFilteringDisplay() {
        const total = $archives.$episodes.length;
        let hiding = 0;
    
        const filterClasses = [
    Severity: Minor
    Found in resources/assets/js/modules/archive.js - About 1 hr to fix

      Function getEpisode has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  getEpisode: function(episode, autoplay) {
                      const self = this;
      
                      // Clear episode data and reset player state
                      this.episodeData = false;
      Severity: Minor
      Found in resources/assets/js/modules/player.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (let i = 0; i < $archives.$sidebar.$categories.length; i++) {
                $archives.$sidebar.$categories[i].addEventListener('change', categoryBehaviour);
            }
        Severity: Major
        Found in resources/assets/js/modules/archive.js and 1 other location - About 1 hr to fix
        resources/assets/js/modules/archive.js on lines 265..267

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (let i = 0; i < $archives.$sidebar.$years.length; i++) {
                $archives.$sidebar.$years[i].addEventListener('change', yearsBehaviour);
            }
        Severity: Major
        Found in resources/assets/js/modules/archive.js and 1 other location - About 1 hr to fix
        resources/assets/js/modules/archive.js on lines 270..272

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function yearsBehaviour has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function yearsBehaviour() {
            const totalLength = $archives.$sidebar.$years.length;
            let yearsActive = 0;
            for (let i = 0; i < $archives.$sidebar.$years.length; i++) {
                if ($archives.$sidebar.$years[i].checked === true) {
        Severity: Minor
        Found in resources/assets/js/modules/archive.js - About 1 hr to fix

          Function togglePlay has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      togglePlay: function(target, event) {
                          const self = this;
          
                          if (event !== null) {
                              event.preventDefault();
          Severity: Minor
          Found in resources/assets/js/modules/player.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (let i = 0; i < $archives.$episodes.length; i++) {
                        $archives.$episodes[i].classList.remove('filter-category');
                    }
            Severity: Minor
            Found in resources/assets/js/modules/archive.js and 1 other location - About 55 mins to fix
            resources/assets/js/modules/archive.js on lines 133..135

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (let i = 0; i < $archives.$episodes.length; i++) {
                        $archives.$episodes[i].classList.add('filter-category');
                    }
            Severity: Minor
            Found in resources/assets/js/modules/archive.js and 1 other location - About 55 mins to fix
            resources/assets/js/modules/archive.js on lines 128..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function categoryBehaviour has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function categoryBehaviour() {
                const selectedCategory = this.value;
            
                if (selectedCategory === 'all') {
                    for (let i = 0; i < $archives.$episodes.length; i++) {
            Severity: Minor
            Found in resources/assets/js/modules/archive.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function createCache() {
                $archives.$sidebar.$years = $archives.$sidebar.getElementsByClassName('js-year');
                $archives.$sidebar.$categories = $archives.$sidebar.getElementsByClassName('js-category');
            
                const filterArray = function(key, attribute) {
            Severity: Minor
            Found in resources/assets/js/modules/archive.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function resetBehaviour has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function resetBehaviour(event) {
                if (event !== null) {
                    event.preventDefault();
                }
            
            
            Severity: Minor
            Found in resources/assets/js/modules/archive.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function searchBehaviour has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function searchBehaviour() {
                let value = this.value;
            
                // Ignore non-alphanumeric and whitespace characters
                value = value.replace(/[^a-zA-Z0-9]/gi, ' ');
            Severity: Minor
            Found in resources/assets/js/modules/archive.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getTitle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getTitle($short) {
            
                    $type = $this->type;
                    $number = $this->number;
                    $title = $this->title;
            Severity: Minor
            Found in app/Episode.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language