Showing 23 of 23 total issues
The class Formatter has an overall complexity of 50 which is very high. The configured complexity threshold is 50. Open
final class Formatter {
use Unconstructable;
/**
* Format the given pattern by replacing positional and named placeholders
- Exclude checks
Function formatArg
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
private static function formatArg($arg, bool $sign, int $decimals, string $format, string $conjunction): string {
if ($conjunction === '?') {
$type = Value::getType($arg);
if ($type === Value::TYPE_RESOURCE) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method formatArg
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static function formatArg($arg, bool $sign, int $decimals, string $format, string $conjunction): string {
if ($conjunction === '?') {
$type = Value::getType($arg);
if ($type === Value::TYPE_RESOURCE) {
Method format
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function format(string $pattern, array $arguments): string {
if (\strpos($pattern, '[') !== \false) {
$pattern = \preg_replace_callback(
/* @lang RegExp */
'/(?<!\[)\[((?:[^\[\]]|(?R))+)](?!])/',
Avoid variables with short names like $c. Configured minimum length is 3. Open
$c = \count($arg);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $cc. Configured minimum length is 3. Open
private static function formatControlChars(string $string, string $del, callable $cc): string {
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Method formatArrayArg
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
private static function formatArrayArg(string $type, array $arg, bool $sign, int $decimals, string $format, string $conjunction): string {
Method formatArg
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private static function formatArg($arg, bool $sign, int $decimals, string $format, string $conjunction): string {
Avoid too many return
statements within this method. Open
return self::formatArrayArg(\get_class($arg), \iterator_to_array($arg, \false), $sign, $decimals, $format, $conjunction);
Avoid too many return
statements within this method. Open
return self::formatNumber($arg->toInt(), $sign, $decimals, $format);
Avoid too many return
statements within this method. Open
return $arg ? 'TRUE' : 'FALSE';
Avoid too many return
statements within this method. Open
return 'void';
Avoid too many return
statements within this method. Open
return \str_replace(['{{', '}}', '[[', ']]'], ['{', '}', '[', ']'], $pattern);
Avoid too many return
statements within this method. Open
return self::formatNumber($arg->toFloat(), $sign, $decimals, $format);
Avoid too many return
statements within this method. Open
return self::formatString(\get_class($arg), $arg->toString(), $format);
Avoid too many return
statements within this method. Open
return self::formatString(\get_class($arg), (string) $arg, $format);
Avoid too many return
statements within this method. Open
return self::formatNumber($arg, $sign, $decimals, $format);
Function formatControlChars
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private static function formatControlChars(string $string, string $del, callable $cc): string {
$result = '';
for ($i = 0, $bytes = \strlen($string); $i < $bytes; ++$i) {
$ord = \ord($string{$i});
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function formatNumber
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private static function formatNumber($arg, bool $sign, int $decimals, string $format): string {
if ($format) {
if ($format === 'e') {
$pattern = '%';
$sign && $pattern .= '+';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function formatString
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private static function formatString(string $type, string $arg, string $format): string {
if ($arg === '') {
return "empty {$type}";
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"