Floppy/dataslate

View on GitHub
src/components/WH40k9e/Roster.tsx

Summary

Maintainability
F
5 days
Test Coverage

Function Roster has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function Roster (props: Props): JSX.Element {
  const headingStyle = {
    background: '#FF6F2D',
    color: 'black',
    padding: '10px',
Severity: Major
Found in src/components/WH40k9e/Roster.tsx - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <Phase name='morale'>
            <AbilityList abilities={props.abilities} phase='morale' />
            <CardColumns className='units'>
              {props.units.map((unit: Unit) => (
                <MoralePhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 1 other location - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 88..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <Phase name='movement'>
            <AbilityList abilities={props.abilities} phase='movement' />
            <CardColumns className='units'>
              {props.units.map((unit: Unit) => (
                <MovementPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 1 other location - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 133..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Phase name='fight'>
            <AbilityList abilities={props.abilities} phase='fight' />
            <>
              {props.units.map((unit: Unit) => (
                <FightPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 3 other locations - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 79..87
    src/components/WH40k9e/Roster.tsx on lines 106..114
    src/components/WH40k9e/Roster.tsx on lines 115..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Phase name='charge'>
            <AbilityList abilities={props.abilities} phase='charge' />
            <>
              {props.units.map((unit: Unit) => (
                <ChargePhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 3 other locations - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 79..87
    src/components/WH40k9e/Roster.tsx on lines 106..114
    src/components/WH40k9e/Roster.tsx on lines 124..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Phase name='shooting'>
            <AbilityList abilities={props.abilities} phase='shooting' />
            <>
              {props.units.map((unit: Unit) => (
                <ShootingPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 3 other locations - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 79..87
    src/components/WH40k9e/Roster.tsx on lines 115..123
    src/components/WH40k9e/Roster.tsx on lines 124..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <Phase name='deployment'>
            <AbilityList abilities={props.abilities} phase='deployment' />
            <>
              {props.units.map((unit: Unit) => (
                <DeploymentPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 1 other location - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 70..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <Phase name='start of battle round'>
            <AbilityList abilities={props.abilities} phase='battle_round_start' />
            <>
              {props.units.map((unit: Unit) => (
                <BattleRoundStartPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 1 other location - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 61..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Phase name='command'>
            <AbilityList abilities={props.abilities} phase='command' />
            <>
              {props.units.map((unit: Unit) => (
                <CommandPhaseDetails key={unit.id} unit={unit} />
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 3 other locations - About 4 hrs to fix
    src/components/WH40k9e/Roster.tsx on lines 106..114
    src/components/WH40k9e/Roster.tsx on lines 115..123
    src/components/WH40k9e/Roster.tsx on lines 124..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            <Col style={{ flexGrow: 0, textAlign: 'right' }}>
              <CloseButton onClose={props.onClose} />
            </Col>
    Severity: Major
    Found in src/components/WH40k9e/Roster.tsx and 2 other locations - About 40 mins to fix
    src/components/KillTeam2018/Roster.tsx on lines 48..50
    src/components/KillTeam2021/Roster.tsx on lines 50..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status