Sign upLogin

FluentLenium/FluentLenium

View on GitHub
Star
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void notHasRectangleWithX() {
        when(rectangle.getX()).thenReturn(RECTANGLE_X_VALID_POS);

        assertThat(conditions.not().rectangle().x(RECTANGLE_X_VALID_POS)).isFalse();
Severity: Major
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 1 other location - About 1 hr to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 80..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void notWithX() {
        when(rectangle.getX()).thenReturn(RECTANGLE_X_VALID_POS);

        assertThat(conditions.rectangle().not().x(RECTANGLE_X_VALID_POS)).isFalse();
Severity: Major
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 1 other location - About 1 hr to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 91..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void withY() {
        when(rectangle.getY()).thenReturn(RECTANGLE_Y_VALID_POS);

        assertThat(conditions.rectangle().y(RECTANGLE_Y_VALID_POS)).isTrue();
Severity: Major
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 2 other locations - About 1 hr to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 69..78
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 122..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void withX() {
        when(rectangle.getX()).thenReturn(RECTANGLE_X_VALID_POS);

        assertThat(conditions.rectangle().x(RECTANGLE_X_VALID_POS)).isTrue();
Severity: Major
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 2 other locations - About 1 hr to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 102..111
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 122..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void withWidth() {
        when(rectangle.getWidth()).thenReturn(RECTANGLE_WIDTH);

        assertThat(conditions.rectangle().width(RECTANGLE_WIDTH)).isTrue();
Severity: Major
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 2 other locations - About 1 hr to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 69..78
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 102..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void withPosition() {
        when(rectangle.getX()).thenReturn(RECTANGLE_X_POS);
        when(rectangle.getY()).thenReturn(RECTANGLE_Y_POS);
Severity: Minor
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 1 other location - About 50 mins to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 147..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void withDimension() {
        when(rectangle.getWidth()).thenReturn(RECTANGLE_DIMENSION_WIDTH);
        when(rectangle.getHeight()).thenReturn(RECTANGLE_DIMENSION_HEIGHT);
Severity: Minor
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java and 1 other location - About 50 mins to fix
fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java on lines 113..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Name 'io.fluentlenium.core.conditions' must match pattern '^org.[a-z]+(.[a-zA-Z_][a-zA-Z0-9_]*)*$'.
Open

package io.fluentlenium.core.conditions;
Severity: Minor
Found in fluentlenium-core/src/test/java/io/fluentlenium/core/conditions/RectangleConditionsTest.java by checkstyle

Checks that package names conform to a specified pattern.

The default value of format for module PackageName has beenchosen to match the requirements in the JavaLanguage specification and the Sun coding conventions. Howeverboth underscores and uppercase letters are rather uncommon, so mostconfigurations should probably assign value ^[a-z]+(\.[a-z][a-z0-9]*)*$ toformat for module PackageName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status