FluxorOrg/Fluxor

View on GitHub
Sources/Fluxor/Selector.swift

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Function with has 6 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

    static func with<S1, S2, S3, S4, S5>(_ selector1: S1,
                                         _ selector2: S2,
                                         _ selector3: S3,
                                         _ selector4: S4,
                                         _ selector5: S5,
Severity: Minor
Found in Sources/Fluxor/Selector.swift - About 45 mins to fix

    Function with has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        static func with<S1, S2, S3, S4>(_ selector1: S1,
                                         _ selector2: S2,
                                         _ selector3: S3,
                                         _ selector4: S4,
                                         projector: @escaping (S1.Value, S2.Value, S3.Value, S4.Value) -> Value)
    Severity: Minor
    Found in Sources/Fluxor/Selector.swift - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

      /*
       * Fluxor
       *  Copyright (c) Morten Bjerg Gregersen 2020
       *  MIT license, see LICENSE file for details
       */
      Severity: Major
      Found in Sources/Fluxor/Selector.swift and 1 other location - About 1 hr to fix
      Sources/Fluxor/Selector.swift on lines 191..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          public init(_ selector1: S1,
                      _ selector2: S2,
                      _ selector3: S3,
                      _ selector4: S4,
                      _ selector5: S5,
      Severity: Major
      Found in Sources/Fluxor/Selector.swift and 1 other location - About 1 hr to fix
      Sources/Fluxor/Selector.swift on lines 1..340

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          public init(_ selector1: S1,
                      _ selector2: S2,
                      _ selector3: S3,
                      _ selector4: S4,
                      _ projector: @escaping (S1.Value, S2.Value, S3.Value, S4.Value) -> Value) {
      Severity: Minor
      Found in Sources/Fluxor/Selector.swift and 1 other location - About 55 mins to fix
      Sources/Fluxor/Selector.swift on lines 1..340

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          public init(_ selector1: S1,
                      _ selector2: S2,
                      _ selector3: S3,
                      _ projector: @escaping (S1.Value, S2.Value, S3.Value) -> Value) {
              self.projector = projector
      Severity: Minor
      Found in Sources/Fluxor/Selector.swift and 1 other location - About 40 mins to fix
      Sources/Fluxor/Selector.swift on lines 1..340

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status