Showing 16 of 16 total issues
Method set_output_paths
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def set_output_paths
if @options[:output].is_a? Hash
@options[:output] = symbolize_hash(@options[:output])
unless @options[:output].has_key? :fonts
raise Fontcustom::Error,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method font_face
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
def font_face(style = {})
if style.is_a?(Symbol)
if style == :preprocessor
url = "font-url"
path = @font_path_alt
Method callback
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def callback
Proc.new do |modified, added, removed|
begin
say_message :changed, modified.join(", ") unless modified.empty?
say_message :added, added.join(", ") unless added.empty?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_input_paths
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def set_input_paths
if @options[:input].is_a? Hash
@options[:input] = symbolize_hash(@options[:input])
if @options[:input].has_key? :vectors
check_input @options[:input][:vectors]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function make_eot_header
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def make_eot_header(fontdata):
"""given ttf font data produce an EOT header"""
fontDataSize = len(fontdata)
font = get_table_directory(fontdata)
Method set_output_paths
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def set_output_paths
if @options[:output].is_a? Hash
@options[:output] = symbolize_hash(@options[:output])
unless @options[:output].has_key? :fonts
raise Fontcustom::Error,
Method load_config
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def load_config
@config_options = {}
if @cli_options[:config]
begin
config = YAML.load File.open(@cli_options[:config])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_glyph_info
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def set_glyph_info
manifest_glyphs = @manifest.get :glyphs
codepoint = if ! manifest_glyphs.empty?
codepoints = manifest_glyphs.values.map { |data| data[:codepoint] }
codepoints.max + 1
Method set_input_paths
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def set_input_paths
if @options[:input].is_a? Hash
@options[:input] = symbolize_hash(@options[:input])
if @options[:input].has_key? :vectors
check_input @options[:input][:vectors]
Method check_template_paths
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def check_template_paths
@options[:templates].each do |template|
next if %w|preview css scss scss-rails|.include? template
if template[0] == "/"
path = template
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_config_path
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def set_config_path
@cli_options[:config] = if @cli_options[:config]
path = @cli_options[:config]
if File.exists?(path) && ! File.directory?(path)
path
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
if os.name == 'nt':
subprocess.call('move ' + fontfile + '.eotlite ' + fontfile + '.eot', shell=True)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 37.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method font_face
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def font_face(style = {})
if style.is_a?(Symbol)
if style == :preprocessor
url = "font-url"
path = @font_path_alt
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_glyph_info
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def set_glyph_info
manifest_glyphs = @manifest.get :glyphs
codepoint = if ! manifest_glyphs.empty?
codepoints = manifest_glyphs.values.map { |data| data[:codepoint] }
codepoints.max + 1
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createGlyph
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def createGlyph( name, source, code ):
frag, ext = os.path.splitext(source)
if ext == '.svg':
temp = removeSwitchFromSvg(source)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_target_path
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def get_target_path(source)
ext = File.extname source
base = File.basename source
css_exts = %w|.css .scss .sass .less .stylus|
packaged = %w|fontcustom-preview.html fontcustom.css _fontcustom.scss _fontcustom-rails.scss|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"