Sign upLogin

ForestAdmin/django-forest

View on GitHub
Star

Showing 39 of 39 total issues

Function _handle_smart_field_for_relation has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _handle_smart_field_for_relation(self, queryset, relation_field, collection_name, params, many):
Severity: Minor
Found in django_forest/resources/utils/smart_field.py - About 35 mins to fix

    Function enhance_queryset has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def enhance_queryset(self, queryset, Model, params, request, apply_pagination=True):
    Severity: Minor
    Found in django_forest/resources/utils/queryset/__init__.py - About 35 mins to fix

      Function get_date_range has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def get_date_range(
      Severity: Minor
      Found in django_forest/resources/utils/queryset/filters/date/utils.py - About 35 mins to fix

        Function handle_smart_fields has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def handle_smart_fields(self, queryset, resource, params=None, many=False, follow_relations=True):
        Severity: Minor
        Found in django_forest/resources/utils/smart_field.py - About 35 mins to fix

          Function get_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_fields(self, current_collection, qs):
        current_name = current_collection['name']
        qs_fields = qs.get('fields')
        if not qs_fields:
            return {
          Severity: Minor
          Found in django_forest/resources/utils/json_api_serializer.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          INSENSITIVE_OPERATORS = {
    'not': '__iexact',
    'contains': '__icontains',
    'not_contains': '__icontains',
    'before': '__lt',
          Severity: Minor
          Found in django_forest/resources/utils/queryset/filters/utils.py and 1 other location - About 35 mins to fix
          django_forest/resources/utils/queryset/filters/utils.py on lines 12..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function get_attribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_attribute(self, obj, attr, default):
        value = super().get_attribute(obj, attr, default)
        if value.__class__.__name__ == 'ManyRelatedManager':
            value = value.all()
        else:
          Severity: Minor
          Found in django_forest/utils/schema/json_api_schema.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          OPERATORS = {
    'not': '',
    'contains': '__contains',
    'not_contains': '__contains',
    'before': '__lt',
          Severity: Minor
          Found in django_forest/resources/utils/queryset/filters/utils.py and 1 other location - About 35 mins to fix
          django_forest/resources/utils/queryset/filters/utils.py on lines 28..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function get_basic_expression has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_basic_expression(self, field, field_type, operator, value):
        operators = INSENSITIVE_OPERATORS if isinstance(value, str) else OPERATORS

        try:
            lookup_field = f"{field}{operators[operator]}"
          Severity: Minor
          Found in django_forest/resources/utils/queryset/filters/utils.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          def get_previous_x_months(current_datetime: datetime, period: int = 0, offset: int = 0) -> tuple:
    return get_date_range(current_datetime, 'MS', period, offset=offset)
          Severity: Major
          Found in django_forest/resources/utils/queryset/filters/date/utils.py and 4 other locations - About 30 mins to fix
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 52..53
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 58..59
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 64..65
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 67..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          def get_previous_x_years(current_datetime: datetime, period: int = 0, offset: int = 0) -> tuple:
    return get_date_range(current_datetime, 'YS', period, offset=offset)
          Severity: Major
          Found in django_forest/resources/utils/queryset/filters/date/utils.py and 4 other locations - About 30 mins to fix
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 52..53
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 58..59
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 61..62
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 67..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          def get_previous_x_quarters(current_datetime: datetime, period: int = 0, offset: int = 0) -> tuple:
    return get_date_range(current_datetime, 'QS', period, offset=offset)
          Severity: Major
          Found in django_forest/resources/utils/queryset/filters/date/utils.py and 4 other locations - About 30 mins to fix
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 52..53
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 58..59
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 61..62
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 64..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          def get_previous_x_days(current_datetime: datetime, period: int = 0, offset: int = 0) -> tuple:
    return get_date_range(current_datetime, 'd', period, offset=offset)
          Severity: Major
          Found in django_forest/resources/utils/queryset/filters/date/utils.py and 4 other locations - About 30 mins to fix
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 58..59
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 61..62
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 64..65
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 67..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          def get_previous_x_weeks(current_datetime: datetime, period: int = 0, offset: int = 0) -> tuple:
    return get_date_range(current_datetime, 'W-MON', period, offset=offset)
          Severity: Major
          Found in django_forest/resources/utils/queryset/filters/date/utils.py and 4 other locations - About 30 mins to fix
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 52..53
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 61..62
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 64..65
          django_forest/resources/utils/queryset/filters/date/utils.py on lines 67..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _get_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_action(self, action_name):
        for collection_schema in Collection._registry.values():
            for action in collection_schema.actions:
                if self.action_name_from_endpoint(action) == action_name:
                    return action
          Severity: Minor
          Found in django_forest/actions/hooks/views/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handle_validators has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def handle_validators(validators, f):
    if len(validators):
        for validator in validators:
            if hasattr(validator, 'code'):
                f = handle_validator(validator, f)
          Severity: Minor
          Found in django_forest/utils/schema/validations.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handle_smart_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def handle_smart_fields(self, queryset, resource, params=None, many=False, follow_relations=True):
        collection = Schema.get_collection(resource)

        # Rather than calculate and then filter out smart fields, we want to ignore them entirely
        smart_fields = self._get_smart_fields_for_request(collection, params)
          Severity: Minor
          Found in django_forest/resources/utils/smart_field.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function populate_query_request_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def populate_query_request_info(self, permission_name, body, kwargs):
        if permission_name in 'liveQueries':
            kwargs['query_request_info'] = body['query']
        elif permission_name in 'statsWithParameters':
            if 'timezone' in body:
          Severity: Minor
          Found in django_forest/middleware/permissions.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_expression_smart_field has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_expression_smart_field(self, smart_fields, condition, resource):
        operator = condition['operator']
        splitted_fields = condition['field'].split(":")
        value = condition['value']
          Severity: Minor
          Found in django_forest/resources/utils/queryset/filters/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language