Sign upLogin

ForestAdmin/forest-express

View on GitHub
Star

Showing 255 of 261 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  const getSubscriptions = (request, response, next) => {
    new SubscriptionsGetter(
      Implementation,
      _.extend(request.query, request.params),
      opts,
Severity: Major
Found in src/integrations/stripe/routes.js and 2 other locations - About 4 hrs to fix
src/integrations/stripe/routes.js on lines 44..60
src/integrations/stripe/routes.js on lines 88..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  const getInvoices = (request, response, next) => {
    new InvoicesGetter(
      Implementation,
      _.extend(request.query, request.params),
      opts,
Severity: Major
Found in src/integrations/stripe/routes.js and 2 other locations - About 4 hrs to fix
src/integrations/stripe/routes.js on lines 44..60
src/integrations/stripe/routes.js on lines 151..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function BaseOperatorDateParser has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function BaseOperatorDateParser(options) {
  const offsetClient = Number.parseInt(moment().tz(options.timezone).format('Z'), 10);
  const offsetServer = moment().utcOffset() / 60;

  this.offsetHours = offsetServer - offsetClient;
Severity: Major
Found in src/services/base-operator-date-parser.js - About 4 hrs to fix

    Function IntercomChecker has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function IntercomChecker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
    Severity: Major
    Found in src/integrations/intercom/index.js - About 4 hrs to fix

      Function ResourceSerializer has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

      function ResourceSerializer(
  Implementation,
  model,
  records,
  integrator,
      Severity: Minor
      Found in src/serializers/resource.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Routes has 109 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function Routes(app, model, Implementation, opts) {
  const { modelsManager } = inject();
  const modelName = Implementation.getModelName(model);
  let integrationInfo;
      Severity: Major
      Found in src/integrations/close.io/routes.js - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case 'previous_year': {
        const penultimatePeriod = moment().subtract(2, PERIODS[operator]);

        return {
          [options.operators.GTE]: this.toDateWithTimezone(penultimatePeriod.clone()
        Severity: Major
        Found in src/services/base-operator-date-parser.js and 1 other location - About 4 hrs to fix
        src/services/base-operator-date-parser.js on lines 77..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case 'previous_year': {
        const previousPeriod = moment().subtract(1, PERIODS[operator]);

        return {
          [options.operators.GTE]: this.toDateWithTimezone(previousPeriod.clone()
        Severity: Major
        Found in src/services/base-operator-date-parser.js and 1 other location - About 4 hrs to fix
        src/services/base-operator-date-parser.js on lines 152..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function Checker has 106 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Checker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function upgradeIntegrationInPlace(stripe) {
        Severity: Major
        Found in src/integrations/stripe/index.js - About 4 hrs to fix

          Function init has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.init = async (Implementation) => {
  const { opts } = Implementation;

  configStore.Implementation = Implementation;
  configStore.lianaOptions = opts;
          Severity: Minor
          Found in src/index.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SmartFieldsValuesInjector has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
          Open

          function SmartFieldsValuesInjector(
  record,
  modelName,
  fieldsPerModel,
  depth = 0,
          Severity: Minor
          Found in src/services/smart-fields-values-injector.js - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SchemaSerializer has 101 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function SchemaSerializer() {
  const { apimapSorter } = inject();
  // WARNING: Attributes declaration order is important for .forestadmin-schema.json format.
  //          It must be ordered by "importance" to ease the JSON reading for users.
  const options = {
          Severity: Major
          Found in src/serializers/schema.js - About 4 hrs to fix

            Function Checker has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function Checker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
            Severity: Minor
            Found in src/integrations/layer/index.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function Checker has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function Checker(options, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
            Severity: Minor
            Found in src/integrations/mixpanel/index.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function Checker has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function Checker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
            Severity: Minor
            Found in src/integrations/close.io/index.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createCollections has 94 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.createCollections = (Implementation, apimap, collectionAndFieldName, options) => {
  const { modelsManager } = inject();
  const model = modelsManager.getModels()[collectionAndFieldName.split('.')[0]];
  const modelName = Implementation.getModelName(model);
  const collectionDisplayName = _.capitalize(modelName);
            Severity: Major
            Found in src/integrations/mixpanel/setup.js - About 3 hrs to fix

              Function Checker has 94 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function Checker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
              Severity: Major
              Found in src/integrations/close.io/index.js - About 3 hrs to fix

                Function Checker has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function Checker(opts, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
                Severity: Major
                Found in src/integrations/layer/index.js - About 3 hrs to fix

                  Function Routes has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function Routes(app, model, Implementation, opts) {
  const { modelsManager } = inject();
  const modelName = Implementation.getModelName(model);
  let integrationInfo;
                  Severity: Major
                  Found in src/integrations/layer/routes.js - About 3 hrs to fix

                    Function Checker has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function Checker(options, Implementation) {
  const { modelsManager } = inject();
  let integrationValid = false;

  function hasIntegration() {
                    Severity: Major
                    Found in src/integrations/mixpanel/index.js - About 3 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language