ForestAdmin/forest-rails

View on GitHub
app/services/forest_liana/oidc_client_manager.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
80%

Method get_client has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    def self.get_client
      begin
        configuration = ForestLiana::OidcConfigurationRetriever.retrieve()
        if ForestLiana.forest_client_id.nil?
          client_data = Rails.cache.read("#{ForestLiana.env_secret}-client-data") || nil
Severity: Minor
Found in app/services/forest_liana/oidc_client_manager.rb - About 1 hr to fix

    Method get_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        def self.get_client
          begin
            configuration = ForestLiana::OidcConfigurationRetriever.retrieve()
            if ForestLiana.forest_client_id.nil?
              client_data = Rails.cache.read("#{ForestLiana.env_secret}-client-data") || nil
    Severity: Minor
    Found in app/services/forest_liana/oidc_client_manager.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status