Sign upLogin

ForestAdmin/forest-rails

View on GitHub
Star
app/services/forest_liana/operator_date_interval_parser.rb

Summary

Maintainability
A
3 hrs
Test Coverage
D
69%

Method get_date_filter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def get_date_filter(operator, value)
      return nil unless is_date_operator? operator

      filter = case operator
        when OPERATOR_FUTURE
Severity: Minor
Found in app/services/forest_liana/operator_date_interval_parser.rb - About 1 hr to fix

    Method get_date_filter_for_previous_interval has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_date_filter_for_previous_interval(operator, value)
      return nil unless has_previous_interval? operator

      case operator
      when OPERATOR_TODAY
    Severity: Minor
    Found in app/services/forest_liana/operator_date_interval_parser.rb - About 1 hr to fix

      Method get_date_filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_date_filter(operator, value)
      return nil unless is_date_operator? operator

      filter = case operator
        when OPERATOR_FUTURE
      Severity: Minor
      Found in app/services/forest_liana/operator_date_interval_parser.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_date_filter_for_previous_interval has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_date_filter_for_previous_interval(operator, value)
      return nil unless has_previous_interval? operator

      case operator
      when OPERATOR_TODAY
      Severity: Minor
      Found in app/services/forest_liana/operator_date_interval_parser.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status