Sign upLogin

ForestAdmin/lumber

View on GitHub
Star

Showing 79 of 79 total issues

Function TableConstraintsGetter has 286 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function TableConstraintsGetter(databaseConnection, schema) {
  const queryInterface = databaseConnection.getQueryInterface();

  this.perform = async (table) => {
    let query = null;
Severity: Major
Found in services/analyzer/sequelize-table-constraints-getter.js - About 1 day to fix

    Function perform has 283 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.perform = async (table) => {
    let query = null;
    const replacements = { table };

    switch (queryInterface.sequelize.options.dialect) {
    Severity: Major
    Found in services/analyzer/sequelize-table-constraints-getter.js - About 1 day to fix

      File sequelize-tables-analyzer.js has 409 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      const P = require('bluebird');
const _ = require('lodash');
const { plural, singular } = require('pluralize');
const ColumnTypeGetter = require('./sequelize-column-type-getter');
const DefaultValueExpression = require('./sequelize-default-value');
      Severity: Minor
      Found in services/analyzer/sequelize-tables-analyzer.js - About 5 hrs to fix

        File dumper.js has 395 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        const _ = require('lodash');
const { plural, singular } = require('pluralize');
const stringUtils = require('../utils/strings');
const toValidPackageName = require('../utils/to-valid-package-name');
const IncompatibleLianaForUpdateError = require('../utils/errors/dumper/incompatible-liana-for-update-error');
        Severity: Minor
        Found in services/dumper.js - About 5 hrs to fix

          Function ColumnTypeGetter has 124 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function ColumnTypeGetter(databaseConnection, schema, allowWarning = true) {
  const queryInterface = databaseConnection.getQueryInterface();

  function isDialect(dialect) {
    return queryInterface.sequelize.options.dialect === dialect;
          Severity: Major
          Found in services/analyzer/sequelize-column-type-getter.js - About 4 hrs to fix

            Function mapCollection has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function mapCollection() {
  function allItemsAreObjectIDs(array) {
    if (!array.length) return false;
    var itemToCheckCount = array.length > 3 ? 3 : array.length;
    var arrayOfObjectIDs = true;
            Severity: Minor
            Found in services/analyzer/mongo-collections-analyzer.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Dumper has 29 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Dumper {
  constructor({
    fs,
    chalk,
    constants,
            Severity: Minor
            Found in services/dumper.js - About 3 hrs to fix

              File sequelize-table-constraints-getter.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              const MysqlTableConstraintsGetter = require('./mysql-table-constraints-getter');

function TableConstraintsGetter(databaseConnection, schema) {
  const queryInterface = databaseConnection.getQueryInterface();
              Severity: Minor
              Found in services/analyzer/sequelize-table-constraints-getter.js - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const detectHasMany = (databaseConnection, fields, collectionName) => {
  const objectIdFields = fields.filter((field) => field.type === OBJECT_ID_ARRAY);
  return P.mapSeries(
    objectIdFields,
    (objectIdField) => detectReference(databaseConnection, objectIdField, collectionName),
                Severity: Major
                Found in services/analyzer/mongo-hasmany-analyzer.js and 1 other location - About 2 hrs to fix
                services/analyzer/mongo-references-analyzer.js on lines 37..43

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 88.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const detectReferences = (databaseConnection, fields, collectionName) => {
  const objectIdFields = fields.filter((field) => field.type === OBJECT_ID);
  return P.mapSeries(
    objectIdFields,
    (objectIdField) => detectReference(databaseConnection, objectIdField, collectionName),
                Severity: Major
                Found in services/analyzer/mongo-references-analyzer.js and 1 other location - About 2 hrs to fix
                services/analyzer/mongo-hasmany-analyzer.js on lines 40..46

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 88.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function perform has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  this.perform = async (columnInfo, columnName, tableName) => {
    const { type } = columnInfo;

    switch (type) {
      case 'JSON':
                Severity: Major
                Found in services/analyzer/sequelize-column-type-getter.js - About 2 hrs to fix

                  Function analyzeSequelizeTables has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  async function analyzeSequelizeTables(connection, config, allowWarning) {
  // User provided a schema, check if it exists
  if (config.dbSchema) {
    const schemas = await connection.query(
      'SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = ?;',
                  Severity: Major
                  Found in services/analyzer/sequelize-tables-analyzer.js - About 2 hrs to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        return this.agent
      .post(`${this.endpoint}/api/application-tokens`)
      .set(HEADER_FOREST_ORIGIN, 'Lumber')
      .set(HEADER_CONTENT_TYPE, HEADER_CONTENT_TYPE_JSON)
      .set(HEADER_USER_AGENT, this.userAgent)
                    Severity: Major
                    Found in services/api.js and 2 other locations - About 2 hrs to fix
                    services/api.js on lines 72..78
                    services/api.js on lines 143..149

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        return this.agent
      .delete(`${this.endpoint}/api/application-tokens`)
      .set(HEADER_FOREST_ORIGIN, 'Lumber')
      .set(HEADER_CONTENT_TYPE, HEADER_CONTENT_TYPE_JSON)
      .set(HEADER_USER_AGENT, this.userAgent)
                    Severity: Major
                    Found in services/api.js and 2 other locations - About 2 hrs to fix
                    services/api.js on lines 72..78
                    services/api.js on lines 127..133

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                          newProject = await this.agent
        .post(`${this.endpoint}/api/projects`)
        .set(HEADER_FOREST_ORIGIN, 'Lumber')
        .set(HEADER_CONTENT_TYPE, HEADER_CONTENT_TYPE_JSON)
        .set(HEADER_USER_AGENT, this.userAgent)
                    Severity: Major
                    Found in services/api.js and 2 other locations - About 2 hrs to fix
                    services/api.js on lines 127..133
                    services/api.js on lines 143..149

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function createAllReferences has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function createAllReferences(databaseSchema, schemaGenerated) {
  const references = {};
  Object.keys(databaseSchema).forEach((tableName) => { references[tableName] = []; });

  Object.keys(databaseSchema).forEach((tableName) => {
                    Severity: Major
                    Found in services/analyzer/sequelize-tables-analyzer.js - About 2 hrs to fix

                      Function mapReduceErrors has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                      Open

                      const mapReduceErrors = (resolve, reject, collectionName) => (err, results) => {
  /* eslint-enable */
  if (err) {
    if (err.message && err.message.startsWith('CMD_NOT_ALLOWED')) {
      logger.warn(`⚠️  [${collectionName}] CMD_NOT_ALLOWED: mapReduce. Please, write manually the Mongoose fields on this collection.  ⚠️`);
                      Severity: Minor
                      Found in services/analyzer/mongo-collections-analyzer.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function dump has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        async dump(schema, config) {
    const cwd = process.cwd();
    const projectPath = config.appName ? `${cwd}/${config.appName}` : cwd;
    const { isUpdate, useMultiDatabase, modelsExportPath } = config;
                      Severity: Minor
                      Found in services/dumper.js - About 1 hr to fix

                        Function MysqlTableConstraintsGetter has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function MysqlTableConstraintsGetter(databaseConnection) {
  const queryInterface = databaseConnection.getQueryInterface();

  // NOTICE: provide an array of array. Each inner array representing a (possibly composite) unique
  //         index
                        Severity: Minor
                        Found in services/analyzer/mysql-table-constraints-getter.js - About 1 hr to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                          const detectReference = (databaseConnection, field, collectionName) =>
  pickSampleValues(databaseConnection, collectionName, field)
    .then((samples) => findCollectionMatchingSamples(databaseConnection, samples))
    .then((matches) => filterReferenceCollection(matches))
    .then((referencedCollection) => buildReference(collectionName, referencedCollection, field));
                          Severity: Major
                          Found in services/analyzer/mongo-hasmany-analyzer.js and 1 other location - About 1 hr to fix
                          services/analyzer/mongo-references-analyzer.js on lines 31..35

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 70.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language