Sign upLogin

ForestAdmin/lumber

View on GitHub
Star
services/analyzer/sequelize-tables-analyzer.js

Summary

Maintainability
D
2 days
Test Coverage
A
94%

File sequelize-tables-analyzer.js has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const P = require('bluebird');
const _ = require('lodash');
const { plural, singular } = require('pluralize');
const ColumnTypeGetter = require('./sequelize-column-type-getter');
const DefaultValueExpression = require('./sequelize-default-value');
Severity: Minor
Found in services/analyzer/sequelize-tables-analyzer.js - About 5 hrs to fix

    Function analyzeSequelizeTables has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function analyzeSequelizeTables(connection, config, allowWarning) {
  // User provided a schema, check if it exists
  if (config.dbSchema) {
    const schemas = await connection.query(
      'SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = ?;',
    Severity: Major
    Found in services/analyzer/sequelize-tables-analyzer.js - About 2 hrs to fix

      Function createAllReferences has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createAllReferences(databaseSchema, schemaGenerated) {
  const references = {};
  Object.keys(databaseSchema).forEach((tableName) => { references[tableName] = []; });

  Object.keys(databaseSchema).forEach((tableName) => {
      Severity: Major
      Found in services/analyzer/sequelize-tables-analyzer.js - About 2 hrs to fix

        Function createReference has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function createReference(
  tableName,
  existingsReferences,
  association,
  foreignKey,
        Severity: Minor
        Found in services/analyzer/sequelize-tables-analyzer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createReference has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function createReference(
  tableName,
  existingsReferences,
  association,
  foreignKey,
        Severity: Minor
        Found in services/analyzer/sequelize-tables-analyzer.js - About 1 hr to fix

          Function analyzeFields has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function analyzeFields(queryInterface, tableName, config) {
  const dialect = queryInterface.sequelize.getDialect();
  let columnsByName;

  // Workaround bug in sequelize/dialects/mysql/query-generator#describe
          Severity: Minor
          Found in services/analyzer/sequelize-tables-analyzer.js - About 1 hr to fix

            Function createReference has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              tableName,
  existingsReferences,
  association,
  foreignKey,
  manyToManyForeignKey,
            Severity: Minor
            Found in services/analyzer/sequelize-tables-analyzer.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (alias.endsWith('Uuid') && alias.length > 4) {
    return alias.substring(0, alias.length - 4);
  }
              Severity: Minor
              Found in services/analyzer/sequelize-tables-analyzer.js and 1 other location - About 35 mins to fix
              services/analyzer/sequelize-tables-analyzer.js on lines 125..127

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (alias.endsWith('Id') && alias.length > 2) {
    return alias.substring(0, alias.length - 2);
  }
              Severity: Minor
              Found in services/analyzer/sequelize-tables-analyzer.js and 1 other location - About 35 mins to fix
              services/analyzer/sequelize-tables-analyzer.js on lines 128..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status