Sign upLogin

ForestAdmin/lumber

View on GitHub
Star
services/authenticator.js

Summary

Maintainability
C
7 hrs
Test Coverage
F
26%

Function createAccount has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async createAccount() {
    this.logger.info('Create an account:');
    const authConfig = await this.inquirer.prompt([{
      type: 'input',
      name: 'firstName',
Severity: Minor
Found in services/authenticator.js - About 1 hr to fix

    Function createAccount has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      async createAccount() {
    this.logger.info('Create an account:');
    const authConfig = await this.inquirer.prompt([{
      type: 'input',
      name: 'firstName',
    Severity: Minor
    Found in services/authenticator.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loginWithEmailOrTokenArgv has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async loginWithEmailOrTokenArgv(config) {
    try {
      const { email, token } = config;
      let { password } = config;
    Severity: Minor
    Found in services/authenticator.js - About 1 hr to fix

      Function loginWithEmailOrTokenArgv has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        async loginWithEmailOrTokenArgv(config) {
    try {
      const { email, token } = config;
      let { password } = config;
      Severity: Minor
      Found in services/authenticator.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loginWithGoogle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        async loginWithGoogle(email) {
    const endpoint = process.env.FOREST_URL && process.env.FOREST_URL.includes('localhost')
      ? 'http://localhost:4200' : 'https://app.forestadmin.com';
    const url = this.chalk.cyan.underline(`${endpoint}/authentication-token`);
    this.logger.info(`To authenticate with your Google account, please follow this link and copy the authentication token: ${url}`);
      Severity: Minor
      Found in services/authenticator.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loginFromCommandLine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        async loginFromCommandLine(config) {
    const { email, token } = config;
    let sessionToken;
    try {
      sessionToken = token || this.fs.readFileSync(this.pathToLumberrc, { encoding: 'utf8' });
      Severity: Minor
      Found in services/authenticator.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          }, {
      type: 'input',
      name: 'email',
      message: 'What\'s your email address?',
      validate: (input) => {
      Severity: Major
      Found in services/authenticator.js and 1 other location - About 1 hr to fix
      lumber-login.js on lines 34..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status