Sign upLogin

Forge-Media/teamspeak-bot

View on GitHub
Star
plugins/registerLOL.js

Summary

Maintainability
D
1 day
Test Coverage

Function onMessage has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Invalid

exports.onMessage = async (msg, jarvis) => {
    const items = msg.split(" <");
    const command = items.shift();
    const invoker = jarvis.invoker;
Severity: Minor
Found in plugins/registerLOL.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onMessage has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

exports.onMessage = async (msg, jarvis) => {
    const items = msg.split(" <");
    const command = items.shift();
    const invoker = jarvis.invoker;
Severity: Major
Found in plugins/registerLOL.js - About 5 hrs to fix

    Function updateUsersTeamspeakGroups has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    function updateUsersTeamspeakGroups(invoker, newRankIndex, notify) {
    // Make sure existing rank is instantiated as an array, to avoid undefined when no existing server group is found!
    let existingTier = [];
    try {
        // Get all the user's existing LOL Teamseak Server Group IDs (Could be multiple, but should not be)
    Severity: Minor
    Found in plugins/registerLOL.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateUsersTeamspeakGroups has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateUsersTeamspeakGroups(invoker, newRankIndex, notify) {
    // Make sure existing rank is instantiated as an array, to avoid undefined when no existing server group is found!
    let existingTier = [];
    try {
        // Get all the user's existing LOL Teamseak Server Group IDs (Could be multiple, but should not be)
    Severity: Minor
    Found in plugins/registerLOL.js - About 1 hr to fix

      Function updateAllUsers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      async function updateAllUsers(jarvis) {
    try {
        // Get all registered members in the League Firebase database
        const members = await jarvis.riot.getAllRegisterdUsers();
      Severity: Minor
      Found in plugins/registerLOL.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                      return;
      Severity: Major
      Found in plugins/registerLOL.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in plugins/registerLOL.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return;
          Severity: Major
          Found in plugins/registerLOL.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return;
            Severity: Major
            Found in plugins/registerLOL.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return; // Is regsitered already
              Severity: Major
              Found in plugins/registerLOL.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return; // Summoner name already registered
                Severity: Major
                Found in plugins/registerLOL.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return;
                  Severity: Major
                  Found in plugins/registerLOL.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return;
                    Severity: Major
                    Found in plugins/registerLOL.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return;
                      Severity: Major
                      Found in plugins/registerLOL.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return;
                        Severity: Major
                        Found in plugins/registerLOL.js - About 30 mins to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Confirmed

                                  if (!config.owners.some((r) => jarvis.groups.indexOf(r) >= 0)) {
            invoker.message(`${jarvis.error_message.forbidden}\n Hi, [color=#0069ff][b]${invoker.nickname}[/b][/color] please [b]Verify[/b] to use this command!`);
            return;
        }
                          Severity: Major
                          Found in plugins/registerLOL.js and 4 other locations - About 2 hrs to fix
                          plugins/registerCSGO.js on lines 49..52
                          plugins/registerCSGO.js on lines 122..125
                          plugins/registerCSGO.js on lines 151..154
                          plugins/registerLOL.js on lines 162..165

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 82.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Confirmed

                                  if (!config.owners.some((r) => jarvis.groups.indexOf(r) >= 0)) {
            invoker.message(`${jarvis.error_message.forbidden}\n Hi, [color=#0069ff][b]${invoker.nickname}[/b][/color] please [b]Verify[/b] to use this command!`);
            return;
        }
                          Severity: Major
                          Found in plugins/registerLOL.js and 4 other locations - About 2 hrs to fix
                          plugins/registerCSGO.js on lines 49..52
                          plugins/registerCSGO.js on lines 122..125
                          plugins/registerCSGO.js on lines 151..154
                          plugins/registerLOL.js on lines 49..52

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 82.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status