Formula9/Framework

View on GitHub
F9/Application/AppFactory.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this method.
Open

        return $app;
Severity: Major
Found in F9/Application/AppFactory.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            $app['flashbag']        = $app->factory(function () use ($app) { return $app['session']->getFlashBag(); });
    Severity: Major
    Found in F9/Application/AppFactory.php - About 30 mins to fix

      Avoid unused private methods such as 'makeApplication'.
      Open

          private function makeApplication(array $paths) : Application
          {
              // this is the Illuminate Container
              $container = Forge::getInstance();
      
      
      Severity: Minor
      Found in F9/Application/AppFactory.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
      {
          private function foo() {} // unused
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      The variable $global_scope is not named in camelCase.
      Open

          private function makeApplication(array $paths) : Application
          {
              // this is the Illuminate Container
              $container = Forge::getInstance();
      
      
      Severity: Minor
      Found in F9/Application/AppFactory.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $global_scope is not named in camelCase.
      Open

          private function makeApplication(array $paths) : Application
          {
              // this is the Illuminate Container
              $container = Forge::getInstance();
      
      
      Severity: Minor
      Found in F9/Application/AppFactory.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $global_scope is not named in camelCase.
      Open

          private function makeApplication(array $paths) : Application
          {
              // this is the Illuminate Container
              $container = Forge::getInstance();
      
      
      Severity: Minor
      Found in F9/Application/AppFactory.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status