Formula9/Framework

Method registerInstances has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private function registerInstances($config, $app, $events, $container, $global_scope)

Avoid too many return statements within this method.

Open

        return [$global_scope, $config, $events];

Avoid too many return statements within this method.

Open

        $container->add('config', function () use ($container) { return $container['Config']; });

Avoid unused private methods such as 'makeConsole'.

Open

    private function makeConsole(array $paths) : Console
    {
        // register and collection common class objects
        list($global_scope, $config, $events) = $this->registerClasses($paths, static::$container);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something
{
    private function foo() {} // unused
}

The parameter $global_scope is not named in camelCase.

Open

    private function registerInstances($config, $app, $events, $container, $global_scope)
    {
        $app['config'] = $config;
        $app['nine.events'] = $events;
        $app['illuminate.container'] = $container;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The variable $global_scope is not named in camelCase.

Open

    private function registerInstances($config, $app, $events, $container, $global_scope)
    {
        $app['config'] = $config;
        $app['nine.events'] = $events;
        $app['illuminate.container'] = $container;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $global_scope is not named in camelCase.

Open

    private function registerClasses(array $paths, $container)
    {
        // we'll start by loading the configuration into the Forge Container
        $container->add(ContainerInterface::class, function () { return Forge::getInstance(); });
        $container->add([Scope::class, 'context'], function () { return new Scope; });

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $global_scope is not named in camelCase.

Open

    private function makeConsole(array $paths) : Console
    {
        // register and collection common class objects
        list($global_scope, $config, $events) = $this->registerClasses($paths, static::$container);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $global_scope is not named in camelCase.

Open

    private function registerClasses(array $paths, $container)
    {
        // we'll start by loading the configuration into the Forge Container
        $container->add(ContainerInterface::class, function () { return Forge::getInstance(); });
        $container->add([Scope::class, 'context'], function () { return new Scope; });

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $global_scope is not named in camelCase.

Open

    private function makeConsole(array $paths) : Console
    {
        // register and collection common class objects
        list($global_scope, $config, $events) = $this->registerClasses($paths, static::$container);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}