Sign upLogin

Formula9/Framework

View on GitHub
Star
F9/Providers/DatabaseServiceProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused local variables such as '$app'.
Open

        list($app, $config, $container) = [$this->app, $this->config, $this->container];
Severity: Minor
Found in F9/Providers/DatabaseServiceProvider.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The variable $config_database is not named in camelCase.
Open

    private function registerDatabases(Container $app)
    {
        if ($this->config['database.database_enabled']) {

            $config_database = $app['config']['database'];
Severity: Minor
Found in F9/Providers/DatabaseServiceProvider.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $config_database is not named in camelCase.
Open

    private function registerDatabases(Container $app)
    {
        if ($this->config['database.database_enabled']) {

            $config_database = $app['config']['database'];
Severity: Minor
Found in F9/Providers/DatabaseServiceProvider.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $config_database is not named in camelCase.
Open

    private function registerDatabases(Container $app)
    {
        if ($this->config['database.database_enabled']) {

            $config_database = $app['config']['database'];
Severity: Minor
Found in F9/Providers/DatabaseServiceProvider.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status