Function register
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
public function register(Container $app)
{
// only register if twig templates are enabled by the framework
if ($this->config['view.twig.enabled']) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method register
has 91 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function register(Container $app)
{
// only register if twig templates are enabled by the framework
if ($this->config['view.twig.enabled']) {
Avoid too many return
statements within this method. Open
return $twig;
Avoid too many return
statements within this method. Open
return new TwigRendererEngine($app['twig.form.templates']);
Avoid too many return
statements within this method. Open
return new \Twig_Loader_Array($app['twig.templates']);
Avoid too many return
statements within this method. Open
return new \Twig_Environment($app['twig.loader'], $app['twig.options']);
Avoid too many return
statements within this method. Open
return new \Twig_Loader_Chain([
$app['twig.loader.array'],
$app['twig.loader.filesystem'],
]);
Avoid too many return
statements within this method. Open
return new TwigRenderer($app['twig.form.engine'], $app['csrf.token_manager']);
The method register() has an NPath complexity of 6193. The configured NPath complexity threshold is 200. Open
public function register(Container $app)
{
// only register if twig templates are enabled by the framework
if ($this->config['view.twig.enabled']) {
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method register() has 138 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function register(Container $app)
{
// only register if twig templates are enabled by the framework
if ($this->config['view.twig.enabled']) {
- Exclude checks
The method register() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10. Open
public function register(Container $app)
{
// only register if twig templates are enabled by the framework
if ($this->config['view.twig.enabled']) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class TwigViewServiceProvider has a coupling between objects value of 23. Consider to reduce the number of dependencies under 13. Open
class TwigViewServiceProvider extends ServiceProvider implements BootableProvider
{
/**
* @param Application|Container $app
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '125', column '28'). Open
return new \Twig_Loader_Array($app['twig.templates']);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '149', column '45'). Open
$twig->addExtension(new \Twig_Extension_Debug());
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '195', column '64'). Open
$app['twig.loader']->{'addLoader'}(new \Twig_Loader_Filesystem($path));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '191', column '42'). Open
$reflected = new \ReflectionClass('Symfony\Bridge\Twig\Extension\FormExtension');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '121', column '28'). Open
return new \Twig_Loader_Filesystem($app['twig.template.paths']);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '129', column '28'). Open
return new \Twig_Loader_Chain([
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '136', column '28'). Open
return new \Twig_Environment($app['twig.loader'], $app['twig.options']);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused local variables such as '$config'. Open
list($config, $container) = [$this->config, $this->container];
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$settings'. Open
$app['twig.settings'] = $settings = $this->config['view.twig.defaults'];
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}