Sign upLogin

Formula9/Framework

View on GitHub
Star
Nine/Library/Arrays.php

Summary

Maintainability
C
1 day
Test Coverage

File Arrays.php has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Nine\Library;

/**
 * @package Nine Library
 * @version 0.3.1
Severity: Minor
Found in Nine/Library/Arrays.php - About 5 hrs to fix

    Function merge_recursive_replace has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function merge_recursive_replace($key, $value)
    {
        // Holds all the arrays passed
        $params = func_get_args();
    Severity: Minor
    Found in Nine/Library/Arrays.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function array_forget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function array_forget(&$array, $keys)
    {
        $original = &$array;

        foreach ((array) $keys as $key) {
    Severity: Minor
    Found in Nine/Library/Arrays.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $default;
    Severity: Major
    Found in Nine/Library/Arrays.php - About 30 mins to fix

      Function array_get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function array_get($array, $key, $default = NULL)
    {
        if (NULL === $key) {
            return $array;
        }
      Severity: Minor
      Found in Nine/Library/Arrays.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function array_query has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function array_query($array, $key, $default = NULL)
    {
        if ($key instanceof \Closure) {
            return $key($array, $default);
        }
      Severity: Minor
      Found in Nine/Library/Arrays.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function array_has has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function array_has($array, $key)
    {
        if ([] === $array || NULL === $key) {
            return FALSE;
        }
      Severity: Minor
      Found in Nine/Library/Arrays.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function array_fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function array_fetch($array, $key)
    {
        $results = [];

        foreach (explode('.', $key) as $segment) {
      Severity: Minor
      Found in Nine/Library/Arrays.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method multi_explode has a boolean flag argument $trim, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public static function multi_explode($string, array $delimiters, $trim = FALSE)
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method array_value uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              else {
            return value($default);
        }
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid assigning values to variables in if clauses and the like (line '183', column '48').
      Open

          public static function array_fetch($array, $key)
    {
        $results = [];

        foreach (explode('.', $key) as $segment) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      The method array_flatten uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  else {
                $results[$prepend . $key] = $value;
            }
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid assigning values to variables in if clauses and the like (line '534', column '14').
      Open

          public static function array_query($array, $key, $default = NULL)
    {
        if ($key instanceof \Closure) {
            return $key($array, $default);
        }
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      The method merge_recursive_replace uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      else {
                    $return[$key] = $value;
                }
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method array_extract uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  else {
                $itemKey = Support::data_get($item, $key);

                $results[$itemKey] = $itemValue;
            }
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid unused local variables such as '$key'.
      Open

              foreach ($array as $key => $field) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid variables with short names like $x. Configured minimum length is 3.
      Open

              array_walk_recursive($array, function ($x) use (&$return) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      The parameter $target_value is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $target_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $find_key is not named in camelCase.
      Open

          public static function extract_column($array, $find_key)
    {
        $result = [];
        foreach ($array as $element) {
            # replaces non-matched items with NULL as a place-keeper.
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $dot_path is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The variable $data_value is not named in camelCase.
      Open

          public static function value_from_notation($array, $key)
    {
        $data_value = $array;
        $valueParts = explode('.', $key);
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $result_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $find_key is not named in camelCase.
      Open

          public static function extract_column($array, $find_key)
    {
        $result = [];
        foreach ($array as $element) {
            # replaces non-matched items with NULL as a place-keeper.
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $dot_path is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $data_value is not named in camelCase.
      Open

          public static function value_from_notation($array, $key)
    {
        $data_value = $array;
        $valueParts = explode('.', $key);
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $target_value is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $data_value is not named in camelCase.
      Open

          public static function value_from_notation($array, $key)
    {
        $data_value = $array;
        $valueParts = explode('.', $key);
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $target_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $data_value is not named in camelCase.
      Open

          public static function value_from_notation($array, $key)
    {
        $data_value = $array;
        $valueParts = explode('.', $key);
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $target_value is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $data_value is not named in camelCase.
      Open

          public static function value_from_notation($array, $key)
    {
        $data_value = $array;
        $valueParts = explode('.', $key);
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $result_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $result_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $result_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $result_array is not named in camelCase.
      Open

          public static function from_notation($dot_path, &$target_array, $target_value = NULL)
    {
        $result_array = &$target_array;

        foreach (explode('.', $dot_path) as $step) {
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $find_key is not named in camelCase.
      Open

          public static function extract_column($array, $find_key)
    {
        $result = [];
        foreach ($array as $element) {
            # replaces non-matched items with NULL as a place-keeper.
      Severity: Minor
      Found in Nine/Library/Arrays.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status