Sign upLogin

Formula9/Framework

View on GitHub
Star
Nine/Views/AbstractView.php

Summary

Maintainability
A
0 mins
Test Coverage

The method addViewPath has a boolean flag argument $prepend, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addViewPath($path, $prepend = TRUE) : array
Severity: Minor
Found in Nine/Views/AbstractView.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The parameter $merge_data is not named in camelCase.
Open

    public function collectScope(array $merge_data = [])
    {
        return $this->scope->merge($merge_data);
    }
Severity: Minor
Found in Nine/Views/AbstractView.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The variable $prepend_or_append is not named in camelCase.
Open

    public function addViewPath($path, $prepend = TRUE) : array
    {
        $prepend_or_append = $prepend ? 'array_unshift' : 'array_push';
        $prepend_or_append($this->templatePaths, $path);
Severity: Minor
Found in Nine/Views/AbstractView.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $merge_data is not named in camelCase.
Open

    public function collectScope(array $merge_data = [])
    {
        return $this->scope->merge($merge_data);
    }
Severity: Minor
Found in Nine/Views/AbstractView.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $prepend_or_append is not named in camelCase.
Open

    public function addViewPath($path, $prepend = TRUE) : array
    {
        $prepend_or_append = $prepend ? 'array_unshift' : 'array_push';
        $prepend_or_append($this->templatePaths, $path);
Severity: Minor
Found in Nine/Views/AbstractView.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status