Sign upLogin

Formula9/Framework

View on GitHub
Star

Showing 487 of 487 total issues

Avoid excessively long variable names like $globalAfterResolvingCallbacks. Keep variable name length under 20.
Open

    protected $globalAfterResolvingCallbacks = [];
Severity: Minor
Found in Nine/Containers/Container.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $afterResolvingCallbacks. Keep variable name length under 20.
Open

    protected $afterResolvingCallbacks = [];
Severity: Minor
Found in Nine/Containers/Container.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $globalResolvingCallbacks. Keep variable name length under 20.
Open

    protected $globalResolvingCallbacks = [];
Severity: Minor
Found in Nine/Containers/Container.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Function extract_dependencies has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function extract_dependencies($class, $method = NULL)
    {
        // collect the request attributes
        $attributes = $this->current_request->attributes->all();
Severity: Minor
Found in Nine/Support/Reflector.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method data_set has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function data_set(&$target, $key, $value, $overwrite = TRUE)
    {
        $segments = is_array($key) ? $key : explode('.', $key);

        if (($segment = array_shift($segments)) === '*') {
Severity: Minor
Found in Nine/Library/Support.php - About 1 hr to fix

    Method set_loader has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function set_loader($configuration)
    {
        switch (TRUE) {

            case ($this->template_type === static::TWIG_LOADER_ARRAY):
    Severity: Minor
    Found in Nine/Views/TwigView.php - About 1 hr to fix

      Method register has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register(Container $app)
    {
        $config = $this->config;

        // optionally include the Blade templating engine.
      Severity: Minor
      Found in F9/Providers/ViewServiceProvider.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function getArrayableItems($items) : array
    {
        if ($items instanceof self) {
            return $items->copy();
        }
        Severity: Major
        Found in Nine/Collections/Attributes.php and 1 other location - About 1 hr to fix
        Nine/Collections/Traits/WithItemArrayAccess.php on lines 182..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function getArrayableItems($items) : array
    {
        if ($items instanceof self) {
            return $items->copy();
        }
        Severity: Major
        Found in Nine/Collections/Traits/WithItemArrayAccess.php and 1 other location - About 1 hr to fix
        Nine/Collections/Attributes.php on lines 162..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function importByExtension has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function importByExtension($extension, $filePath, $key = '')
    {
        $extension = strtolower(str_replace('*', '', $extension));

        if ( ! in_array($extension, ['.json', '.php', '.yaml', '.yml'], TRUE)) {
        Severity: Minor
        Found in Nine/Collections/Config.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method importByExtension has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function importByExtension($extension, $filePath, $key = '')
    {
        $extension = strtolower(str_replace('*', '', $extension));

        if ( ! in_array($extension, ['.json', '.php', '.yaml', '.yml'], TRUE)) {
        Severity: Minor
        Found in Nine/Collections/Config.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (is_array($controller)) {
            $r = new \ReflectionMethod($controller[0], $controller[1]);
        }

        // --or-- if an instantiated controller object which is not a Closure then
          Severity: Major
          Found in Nine/Support/Reflector.php and 1 other location - About 1 hr to fix
          F9/Support/Services/InjectingControllerResolver.php on lines 81..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (is_array($controller)) {
            $reflection = new \ReflectionMethod($controller[0], $controller[1]);
        }

        // --or-- if an instantiated controller object which is not a Closure then
          Severity: Major
          Found in F9/Support/Services/InjectingControllerResolver.php and 1 other location - About 1 hr to fix
          Nine/Support/Reflector.php on lines 72..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method getMethodArguments has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getMethodArguments(Request $request, $controller, array $parameters) : array
    {
        // use this request
        $this->current_request = $request;
          Severity: Minor
          Found in Nine/Support/Reflector.php - About 1 hr to fix

            Method encode_readable_json has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function encode_readable_json($data, $indent = 0)
    {
        $_escape = function ($str) {
            return preg_replace("!([\b\t\n\r\f\"\\'])!", "\\\\\\1", $str);
        };
            Severity: Minor
            Found in Nine/Library/Strings.php - About 1 hr to fix

              Method build has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function build($concrete, array $parameters = [])
    {
        // If the concrete type is actually a Closure, we will just execute it and
        // hand back the results of the functions, which allows functions to be
        // used as resolvers for more fine-tuned resolution of these objects.
              Severity: Minor
              Found in Nine/Containers/Container.php - About 1 hr to fix

                Method getReflection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getReflection($class, $method = NULL)
    {
        $reflection = NULL;

        switch ($class) {
                Severity: Minor
                Found in Nine/Support/Reflector.php - About 1 hr to fix

                  Function getReflection has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getReflection($class, $method = NULL)
    {
        $reflection = NULL;

        switch ($class) {
                  Severity: Minor
                  Found in Nine/Support/Reflector.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method data_get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function data_get($target, $key, $default = NULL)
    {
        if (NULL === $key) {
            return $target;
        }
                  Severity: Minor
                  Found in Nine/Library/Support.php - About 1 hr to fix

                    Function register has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function register(Container $app)
    {
        $app['db.default_options'] = [
            'driver'   => 'pdo_mysql',
            'dbname'   => env('DB_DATABASE', NULL),
                    Severity: Minor
                    Found in F9/Providers/DoctrineServiceProvider.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language