Sign upLogin

FrankProjects/UltimateWarfare

View on GitHub
Star
src/Service/Action/FederationActionService.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function sendAid has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function sendAid(Player $player, int $playerId, array $resources): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
Severity: Minor
Found in src/Service/Action/FederationActionService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sendAid has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendAid(Player $player, int $playerId, array $resources): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
Severity: Major
Found in src/Service/Action/FederationActionService.php - About 2 hrs to fix

    Method kickPlayer has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function kickPlayer(Player $player, int $playerId): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
    Severity: Minor
    Found in src/Service/Action/FederationActionService.php - About 1 hr to fix

      Function changePlayerHierarchy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function changePlayerHierarchy(Player $player, int $playerId, int $role): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
      Severity: Minor
      Found in src/Service/Action/FederationActionService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function kickPlayer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function kickPlayer(Player $player, int $playerId): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
      Severity: Minor
      Found in src/Service/Action/FederationActionService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status