FrankProjects/UltimateWarfare

View on GitHub
src/Service/Action/FederationApplicationActionService.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method acceptFederationApplication has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function acceptFederationApplication(Player $player, int $applicationId): void
    {
        $this->ensureFederationEnabled($player);
        $federation = $player->getFederation();
        if ($federation === null) {
Severity: Minor
Found in src/Service/Action/FederationApplicationActionService.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            FederationRepository $federationRepository,
            FederationApplicationRepository $federationApplicationRepository,
            FederationNewsRepository $federationNewsRepository,
            PlayerRepository $playerRepository,
            ReportRepository $reportRepository
    Severity: Minor
    Found in src/Service/Action/FederationApplicationActionService.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status