Sign upLogin

FrankYan93/nanotwitter

View on GitHub
Star

Showing 7 of 7 total issues

Method check_log_in has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def check_log_in(params)
    if session[:user_id].nil?
        if params[:username].nil?
            not_log_in_home
        else
Severity: Minor
Found in app.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method log_in_home has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def log_in_home
    if session[:user_id].nil?
        not_log_in_home
    else
        # print "userid in session:",session[:user_id],"\n"
Severity: Minor
Found in service/timeline.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateProfileTweets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def updateProfileTweets(userId, n)
    label = userId.to_s + '_tweet'
    # update empty personal tweets list
    tmp = userRecentTweets(userId, n)
    for i in 0...n # the number is same as n-1 in getusertweets api
Severity: Minor
Found in service/updateRedis.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insertIntoAllFollower has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def insertIntoAllFollower(theId, tweet)
    theFollowers = hisFollowers theId
    user=JSON.parse $redis.get("User"+theId.to_s)
    if user.nil?
      user=User.find(theId)
Severity: Minor
Found in service/tweet.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method userProfile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def userProfile theParam
  currentUser=User.find(theParam[:user_id])

  currentUser.password = Password.create(theParam[:password])
  currentUser.birthday = theParam[:birthday] unless theParam[:birthday].nil?
Severity: Minor
Found in api/users/putEditProfile.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

get '/searchTweet' do
    @word = params[:word]
    @tweets = Tweet.where('content LIKE :query', query: "%#{@word}%").all

    @n = params[:n].to_i || 0
Severity: Minor
Found in service/search.rb and 1 other location - About 20 mins to fix
service/search.rb on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

get '/searchUser' do
    @word = params[:word]
    @users = User.where('username LIKE :query', query: "%#{@word}%").all

    @n = params[:n].to_i || 0
Severity: Minor
Found in service/search.rb and 1 other location - About 20 mins to fix
service/search.rb on lines 1..8

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language