FreeAllMedia/forbin

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should call a filter method before update", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(logRequestSpy, updateSpy);
                                done();

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should call a filter method before delete", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(logRequestSpy, deleteSpy);
                                done();

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should set a filter method to be called before the update action as provided in the array", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(
                                    logRequestSpy,

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should set a filter method to be called before the delete action as provided in the array", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(
                                    logRequestSpy,

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should call a filter method before create", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(logRequestSpy, createSpy);
                                done();

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

                    it("should set a filter method to be called before a specific action", done => {
                        mockResponse = {
                            end: () => {
                                sinon.assert.callOrder(
                                    logRequestSpy,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

gulp.task("build-spec-assets", () => {
    return gulp.src(paths.source.specAssets)
        .pipe(gulp.dest(paths.build.directories.spec));
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

gulp.task("build-lib-assets", () => {
    return gulp.src(paths.source.specAssets)
        .pipe(gulp.dest(paths.build.directories.spec));
});

• Read up
  Read up

Function setupFilterProcessor has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  [setupFilterProcessor](actionName) {
    const originalAction = this[actionName];
    const self = this;

    this[actionName] = (request, response) => {

Function skip has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  skip(...options) {
    let filterToAvoid,
      actionsToAvoid;

    switch(options.length) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    it("should skip a filter applied to all actions", done => {
                        callClientControllerActions(
                            clientController,
                            () => {
                                (logRequestSpy.called && logResponse.called).should.be.false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    it("should skip a filter applied to one action", done => {
                        callClientControllerActions(
                            clientController,
                            () => {
                                (logRequestSpy.called && logResponse.called).should.be.false;

• Read up
  Read up

Function addFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  [addFilter](owner, ...options) {
    let filter = null;
    switch(options.length) {
      case 1:
        filter = options[0];

Function actionName has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this[actionName] = (request, response) => {
      let originalEnd;
      if(response && response.end) {
         originalEnd = response.end;
      }

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                    function deleteAction(next) {
                        mockResponse = {
                            end: () => {
                            }
                        };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                    function createAction(next) {
                        mockResponse = {
                            end: () => {
                            }
                        };

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                    function updateAction(next) {
                        mockResponse = {
                            end: () => {
                            }
                        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    it("should skip the filter applied to all just for that action", done => {
                        callClientControllerActions(
                            clientController,
                            () => {
                                logRequestSpy.callCount.should.equals(2);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    it("should skip the filter applied to that specific action", done => {
                        callClientControllerActions(
                            clientController,
                            () => {
                                logRequestSpy.callCount.should.equals(1);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  [processBeforeFilters](action, request, response, callback) {
    this[processFilters](this[getFilters](action, privateData(this)._filters.before), request, response, callback);
  }

• Read up
  Read up