FrenchYeti/dexcalibur

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    if(this.__tmp_block instanceof CLASS.DataBlock || this.__tmp_block.stack.length>0){
                        this.__tmp_meth.appendBlock(this.__tmp_block, this.__appendBlock_callback);
                        this.__tmp_block = new CLASS.BasicBlock();
                    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for(let i=0; i<this.files.length; i++)
            if(this.files[i] != null && this.files[i][cmp](format))
                coll.pushFile(this.files[i]);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    this.metharea.setGlobalSymbol(
                        `${oper.right.enclosingClass.name}.${oper.right.name}`, 
                        DTYPE.FIELD, 
                        regV.getValue(), 
                        `${v[0]} = ${v[1]}`);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    IGET:{ byte:0x52, instr:"iget", parse: MainParser.multRegField, type: CONST.INSTR_TYPE.GETTER, reftype:ReferenceType.FIELD, format:Format.Format22c, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        if(this.isImm(regV)){
                            regX = this.getSymbol(this.getRegisterName(oper.left[0]));

                            v = `${this.getRegisterName(oper.left[0])} = ${this.getImmediateValue(oper.left[1])}+${this.getRegisterName(oper.right)};`;
                            regX.setCode(v);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        if(this.isImm(regV)){

                            regX = this.getRegisterName(oper.left[0]);
                            regX = this.getSymbol(regX);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    INVOKE_VIRTUAL:{ byte:0x6e, instr:"invoke-virtual", parse: MainParser.invoke, type: CONST.INSTR_TYPE.INVOKE, reftype:ReferenceType.METHOD, format:Format.Format35c, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_RESULT },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for(let i=0; i<this.buffers.length; i++)
            if(this.buffers[i] != null && this.buffers[i][cmp](format))
                coll.pushBuffer(this.buffers[i]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    if(this.__tmp_block instanceof CLASS.DataBlock || this.__tmp_block.stack.length>0){
                        this.__tmp_meth.appendBlock(this.__tmp_block, this.__appendBlock_callback);
                        this.__tmp_block = new CLASS.BasicBlock();
                    }

• Read up
  Read up

Function scan has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    async scan(){
        let dev=[], wrapper=null, activeDev = 0, latestDefault=null;

        latestDefault = this.getDefault();

Function makeTree has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Analyzer.prototype.makeTree = function(bblocks){
    let last = {};
    for(let i=0; i<bblocks.length; i++){
        bblocks[i].offset = i;
        if(bblocks[i].stack.length > 0){

Function __checkDeepField has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    __checkDeepField(object,search, offset=0){
        let ref=object, i=offset;

        if(object == null) return false;

Function hook.reflect.method.get has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        "hook.reflect.method.get": function (ctx, event) {
            Logger.info("[INSPECTOR][TASK] DynLoaderInspector search Method ");

            //console.log(event);
            if (event == null || event.data == null || event.data.data == null) return false;

Function getBinding has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.getBinding = function(bind,clsFqcn){
        let cls=null, ef=null, x=null, hash=null;
        
        if(clsFqcn === undefined)
            clsFqcn = bind.fqcn; 

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const ChunkType = {
  NULL: 0x0000,
  STRING_POOL: 0x0001,
  TABLE: 0x0002,
  XML: 0x0003,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var STUB_TYPE={
    METHOD: 0x1,
    FIELD: 0x2,
    ANNOTATION: 0x3,
    INSTR: 0x4,

• Read up
  Read up

Function fromString has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static fromString( pType, pArrayStr){
        const RE  = new RegExp('[\s\t]*\[[\s\t]*(?<ctn>.*)[\s\t]*\][\s\t]*');
        let m = RE.exec(pArrayStr);
        if(m == null){
            throw new VM_Exception('VM002','Unable to parse bytearray parameter: invalid format');

Function getImmediateValue has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getImmediateValue(pSymbol, pSeparator="", pForce=false){
        let v="";
        switch(pSymbol.type)
        {
            case DTYPE.IMM_STRING:

Function deploy has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

HookSet.prototype.deploy = function(){
    let hookManager = this.context.hook; //ctx.hook;
    let hook, method, hconfig;

    // if the hookset is already deployed only not deployed hooks are generated

Function toScript has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    toScript(indentLevel=1){
        let entry=null, out=`{
`;

        for(let i=0; i<this.entries.length; i++){