FrenchYeti/dexcalibur

View on GitHub

Showing 948 of 948 total issues

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    IF_GT:{ byte:0x36, instr:"if-gt", parse: MainParser.multTagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format22t, flag:Opcode.CAN_CONTINUE },
Severity: Major
Found in src/Opcode.js and 11 other locations - About 30 mins to fix
src/Opcode.js on lines 756..756
src/Opcode.js on lines 767..767
src/Opcode.js on lines 768..768
src/Opcode.js on lines 769..769
src/Opcode.js on lines 771..771
src/Opcode.js on lines 772..772
src/Opcode.js on lines 773..773
src/Opcode.js on lines 774..774
src/Opcode.js on lines 775..775
src/Opcode.js on lines 776..776
src/Opcode.js on lines 777..777

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return new SearchPattern({ 
            pattern: pattern, 
            field: token, 
            isStructField: struct,
            isDeepSearch: isDeepSearch,
Severity: Major
Found in src/Finder.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return new FinderResult(this._findObject(index, spatt, includeMissing), this);
    Severity: Major
    Found in src/Finder.js - About 30 mins to fix

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          IF_NEZ:{ byte:0x39, instr:"if-nez", parse: MainParser.tagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format21t, flag:Opcode.CAN_CONTINUE },
      Severity: Major
      Found in src/Opcode.js and 11 other locations - About 30 mins to fix
      src/Opcode.js on lines 756..756
      src/Opcode.js on lines 767..767
      src/Opcode.js on lines 768..768
      src/Opcode.js on lines 769..769
      src/Opcode.js on lines 770..770
      src/Opcode.js on lines 771..771
      src/Opcode.js on lines 772..772
      src/Opcode.js on lines 774..774
      src/Opcode.js on lines 775..775
      src/Opcode.js on lines 776..776
      src/Opcode.js on lines 777..777

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

                              return;
      Severity: Major
      Found in src/WebServer.js - About 30 mins to fix

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

            SPARSE_SWITCH:{ byte:0x2c, instr:"sparse-switch", parse: MainParser.tagged, type: CONST.INSTR_TYPE.SWITCH, reftype:ReferenceType.NONE, format:Format.Format31t, flag:Opcode.CAN_CONTINUE },
        Severity: Major
        Found in src/Opcode.js and 11 other locations - About 30 mins to fix
        src/Opcode.js on lines 767..767
        src/Opcode.js on lines 768..768
        src/Opcode.js on lines 769..769
        src/Opcode.js on lines 770..770
        src/Opcode.js on lines 771..771
        src/Opcode.js on lines 772..772
        src/Opcode.js on lines 773..773
        src/Opcode.js on lines 774..774
        src/Opcode.js on lines 775..775
        src/Opcode.js on lines 776..776
        src/Opcode.js on lines 777..777

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          readLength16() {
            let len = this.readU16();
            if (len & 0x8000) {
              len = (len & 0x7fff) << 16;
              len += this.readU16();
        Severity: Minor
        Found in src/libs/BinaryXmlParser.js and 1 other location - About 30 mins to fix
        src/libs/BinaryXmlParser.js on lines 111..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if(process.env.DEXCALIBUR_JAVA != null){
                    return {file:process.env.DEXCALIBUR_JAVA, args:['-jar',cmd]};
                }else{
                    return {file:'java', args:['-jar',cmd]};
                }
        Severity: Minor
        Found in src/DexHelper.js and 1 other location - About 30 mins to fix
        src/ApkHelper.js on lines 38..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for(let j in src[i].methods){
                        db[i].methods[j] = new Core.Method();
                        db[i].methods[j].import(src[i].methods[j]);
                    }
        Severity: Minor
        Found in src/BackupManager.js and 1 other location - About 30 mins to fix
        src/BackupManager.js on lines 435..438

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                    return false;
        Severity: Major
        Found in src/Finder.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return new FinderResult(new MemoryDb.Index(), this); 
          Severity: Major
          Found in src/Finder.js - About 30 mins to fix

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

                IF_NE:{ byte:0x33, instr:"if-ne", parse: MainParser.multTagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format22t, flag:Opcode.CAN_CONTINUE },
            Severity: Major
            Found in src/Opcode.js and 11 other locations - About 30 mins to fix
            src/Opcode.js on lines 756..756
            src/Opcode.js on lines 768..768
            src/Opcode.js on lines 769..769
            src/Opcode.js on lines 770..770
            src/Opcode.js on lines 771..771
            src/Opcode.js on lines 772..772
            src/Opcode.js on lines 773..773
            src/Opcode.js on lines 774..774
            src/Opcode.js on lines 775..775
            src/Opcode.js on lines 776..776
            src/Opcode.js on lines 777..777

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

                IF_LT:{ byte:0x34, instr:"if-lt", parse: MainParser.multTagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format22t, flag:Opcode.CAN_CONTINUE },
            Severity: Major
            Found in src/Opcode.js and 11 other locations - About 30 mins to fix
            src/Opcode.js on lines 756..756
            src/Opcode.js on lines 767..767
            src/Opcode.js on lines 769..769
            src/Opcode.js on lines 770..770
            src/Opcode.js on lines 771..771
            src/Opcode.js on lines 772..772
            src/Opcode.js on lines 773..773
            src/Opcode.js on lines 774..774
            src/Opcode.js on lines 775..775
            src/Opcode.js on lines 776..776
            src/Opcode.js on lines 777..777

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

                IF_GTZ:{ byte:0x3c, instr:"if-gtz", parse: MainParser.tagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format21t, flag:Opcode.CAN_CONTINUE },
            Severity: Major
            Found in src/Opcode.js and 11 other locations - About 30 mins to fix
            src/Opcode.js on lines 756..756
            src/Opcode.js on lines 767..767
            src/Opcode.js on lines 768..768
            src/Opcode.js on lines 769..769
            src/Opcode.js on lines 770..770
            src/Opcode.js on lines 771..771
            src/Opcode.js on lines 772..772
            src/Opcode.js on lines 773..773
            src/Opcode.js on lines 774..774
            src/Opcode.js on lines 775..775
            src/Opcode.js on lines 777..777

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                        return search.fn(ref);
            Severity: Major
            Found in src/Finder.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return false;
              Severity: Major
              Found in inspectors/BytecodeCleaner/service/main.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return true;
                Severity: Major
                Found in inspectors/BytecodeCleaner/service/main.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          Logger.info("\n\n"
                          + LOGO
                          + PACKAGE_JSON.version
                          + (" ".repeat(78-14-PACKAGE_JSON.version.length))
                          +"by @FrenchYeti \n"
                  Severity: Minor
                  Found in src/DexcaliburEngine.js and 1 other location - About 30 mins to fix
                  src/DexcaliburEngine.js on lines 179..188

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                      IF_LTZ:{ byte:0x3a, instr:"if-ltz", parse: MainParser.tagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format21t, flag:Opcode.CAN_CONTINUE },
                  Severity: Major
                  Found in src/Opcode.js and 11 other locations - About 30 mins to fix
                  src/Opcode.js on lines 756..756
                  src/Opcode.js on lines 767..767
                  src/Opcode.js on lines 768..768
                  src/Opcode.js on lines 769..769
                  src/Opcode.js on lines 770..770
                  src/Opcode.js on lines 771..771
                  src/Opcode.js on lines 772..772
                  src/Opcode.js on lines 773..773
                  src/Opcode.js on lines 775..775
                  src/Opcode.js on lines 776..776
                  src/Opcode.js on lines 777..777

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                      IF_LEZ:{ byte:0x3d, instr:"if-lez", parse: MainParser.tagged, type: CONST.INSTR_TYPE.IF, reftype:ReferenceType.NONE, format:Format.Format21t, flag:Opcode.CAN_CONTINUE },
                  Severity: Major
                  Found in src/Opcode.js and 11 other locations - About 30 mins to fix
                  src/Opcode.js on lines 756..756
                  src/Opcode.js on lines 767..767
                  src/Opcode.js on lines 768..768
                  src/Opcode.js on lines 769..769
                  src/Opcode.js on lines 770..770
                  src/Opcode.js on lines 771..771
                  src/Opcode.js on lines 772..772
                  src/Opcode.js on lines 773..773
                  src/Opcode.js on lines 774..774
                  src/Opcode.js on lines 775..775
                  src/Opcode.js on lines 776..776

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language