Sign upLogin

Freshly/spicerack

View on GitHub
Star
collectible/lib/collectible/collection/maintain_sort_order.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
96%

Method disallow_when_sorted has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def disallow_when_sorted(*methods)
          methods.each do |method_name|
            around_method(method_name, prevent_double_wrapping_for: "MaintainSortingOrder") do |*args, **opts, &block|
              raise Collectible::MethodNotAllowedError, "cannot call #{method_name} when sorted" if maintain_sort_order?
Severity: Minor
Found in collectible/lib/collectible/collection/maintain_sort_order.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Block has too many lines. [33/24]
Open

      class_methods do
        def inherited(base)
          base.maintain_sort_order if maintain_sort_order?
          super
        end
Severity: Minor
Found in collectible/lib/collectible/collection/maintain_sort_order.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

You can set literals you want to fold with CountAsOne. Available are: 'array', 'hash', and 'heredoc'. Each literal will be counted as one line regardless of its actual size.

Example: CountAsOne: ['array', 'heredoc']

something do
  array = [         # +1
    1,
    2
  ]

  hash = {          # +3
    key: 'value'
  }

  msg = <<~HEREDOC  # +1
    Heredoc
    content.
  HEREDOC
end                 # 5 points

There are no issues that match your filters.

Category
Status