Sign upLogin

Freshly/spicerack

View on GitHub
Star
rspice/lib/rspice/custom_matchers/validate.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [30/24]
Open

RSpec::Matchers.define :validate do |attribute|
  match do |subject|
    raise Rspice::IncompleteMatcherError, "validator class not provided" unless @expected_validator.present?

    @validator = subject.class.validators.find do |validator|
Severity: Minor
Found in rspice/lib/rspice/custom_matchers/validate.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

You can set literals you want to fold with CountAsOne. Available are: 'array', 'hash', and 'heredoc'. Each literal will be counted as one line regardless of its actual size.

Example: CountAsOne: ['array', 'heredoc']

something do
  array = [         # +1
    1,
    2
  ]

  hash = {          # +3
    key: 'value'
  }

  msg = <<~HEREDOC  # +1
    Heredoc
    content.
  HEREDOC
end                 # 5 points

Use if @expected_validator.blank? instead of unless @expected_validator.present?.
Open

    raise Rspice::IncompleteMatcherError, "validator class not provided" unless @expected_validator.present?
Severity: Minor
Found in rspice/lib/rspice/custom_matchers/validate.rb by rubocop

This cop checks for code that can be written with simpler conditionals using Object#blank? defined by Active Support.

Interaction with Style/UnlessElse: The configuration of NotPresent will not produce an offense in the context of unless else if Style/UnlessElse is inabled. This is to prevent interference between the auto-correction of the two cops.

Example: NilOrEmpty: true (default)

# Converts usages of `nil? || empty?` to `blank?`

# bad
foo.nil? || foo.empty?
foo == nil || foo.empty?

# good
foo.blank?

Example: NotPresent: true (default)

# Converts usages of `!present?` to `blank?`

# bad
!foo.present?

# good
foo.blank?

Example: UnlessPresent: true (default)

# Converts usages of `unless present?` to `if blank?`

# bad
something unless foo.present?

# good
something if foo.blank?

# bad
unless foo.present?
  something
end

# good
if foo.blank?
  something
end

# good
def blank?
  !present?
end

There are no issues that match your filters.

Category
Status