Sign upLogin

Freshly/spicerack

View on GitHub
Star
tablesalt/lib/tablesalt/rspec/custom_matchers/define_thread_writer.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [53/24]
Invalid

RSpec::Matchers.define :define_thread_writer do |writer_name, thread_key, **options|
  attr_reader :subject, :writer_name, :method_name, :thread_key, :private_opt, :namespace

  description { "define#{a_private} thread writer #{writer_name.inspect} with thread key #{thread_key.inspect}#{namespace_failure_message}" }
Severity: Minor
Found in tablesalt/lib/tablesalt/rspec/custom_matchers/define_thread_writer.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

You can set literals you want to fold with CountAsOne. Available are: 'array', 'hash', and 'heredoc'. Each literal will be counted as one line regardless of its actual size.

Example: CountAsOne: ['array', 'heredoc']

something do
  array = [         # +1
    1,
    2
  ]

  hash = {          # +3
    key: 'value'
  }

  msg = <<~HEREDOC  # +1
    Heredoc
    content.
  HEREDOC
end                 # 5 points

Method instance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Wontfix

  def instance
    return subject unless subject.is_a?(Module)
    return subject unless subject.respond_to?(:new)

    @instance ||= begin
Severity: Minor
Found in tablesalt/lib/tablesalt/rspec/custom_matchers/define_thread_writer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Wontfix

  def instance
    return subject unless subject.is_a?(Module)
    return subject unless subject.respond_to?(:new)

    @instance ||= begin
Severity: Minor
Found in tablesalt/lib/tablesalt/rspec/custom_matchers/define_thread_writer.rb and 1 other location - About 20 mins to fix
tablesalt/lib/tablesalt/rspec/custom_matchers/define_thread_reader.rb on lines 70..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status