FriendsOfPHP/pickle

View on GitHub
src/Package/PHP/Command/Install/Windows/Binary.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method download has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function download($url)
    {
        $progress = $this->progress;
        $progress->setOverwrite(true);
        $ctx = stream_context_create(
Severity: Minor
Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 1 hr to fix

    Function copyFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function copyFiles()
        {
            $DLLs = glob($this->tempDir . '/*.dll');
            $this->extDll = [];
            foreach ($DLLs as $dll) {
    Severity: Minor
    Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findInLinks has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function findInLinks($url, $toFind)
        {
            $page = @file_get_contents($url);
            $opts = [
                'http' => [
    Severity: Minor
    Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 1 hr to fix

      Method getInfoFromPecl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getInfoFromPecl()
          {
              $baseUrl = WebsiteFactory::getWebsite()->getBaseUrl();
              $url = $baseUrl . '/get/' . $this->extName;
              $headers = get_headers($url);
      Severity: Minor
      Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 1 hr to fix

        Function getInfoFromPecl has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getInfoFromPecl()
            {
                $baseUrl = WebsiteFactory::getWebsite()->getBaseUrl();
                $url = $baseUrl . '/get/' . $this->extName;
                $headers = get_headers($url);
        Severity: Minor
        Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findInLinks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function findInLinks($url, $toFind)
            {
                $page = @file_get_contents($url);
                $opts = [
                    'http' => [
        Severity: Minor
        Found in src/Package/PHP/Command/Install/Windows/Binary.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status