Sign upLogin

FriendsOfPHP/pickle

View on GitHub
Star
src/Package/Util/Windows/DependencyLib.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function resolveForBin has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function resolveForBin($dll, $resolve_multiple_cb = null)
    {
        $dep_zips = $this->getZipUrlsForDll($dll, false);

        if (count($dep_zips) == 1) {
Severity: Minor
Found in src/Package/Util/Windows/DependencyLib.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getZipUrlsForDll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function getZipUrlsForDll($binary, $ignore_installed = false)
    {
        $dll = $this->getDllsForBinary($binary);
        $packages = [];
        foreach ($this->dllMap as $pkg_name => $pkg) {
Severity: Minor
Found in src/Package/Util/Windows/DependencyLib.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method download has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function download($url)
    {
        $output = $this->output;
        $progress = $this->progress;
Severity: Minor
Found in src/Package/Util/Windows/DependencyLib.php - About 1 hr to fix

    Function fetchDllMap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function fetchDllMap()
    {
        $dllMap = null;

        if ($this->dllMap === null) {
    Severity: Minor
    Found in src/Package/Util/Windows/DependencyLib.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status