FujitsuLaboratories/cattaz

View on GitHub
src/apps/DateMatcherApplication.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function renderAnswers has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  renderAnswers(model) {
    const { editing } = this.state;
    const header = (
      <tr>
        <th>Attendees / Date</th>
Severity: Major
Found in src/apps/DateMatcherApplication.jsx - About 2 hrs to fix

    Function attendees has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const attendees = Object.keys(model.attendees).map((attendeeName) => {
          const ans = model.attendees[attendeeName] || {};
          const isEditingRow = attendeeName === editing;
          return (
            <tr key={attendeeName}>
    Severity: Minor
    Found in src/apps/DateMatcherApplication.jsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        shouldComponentUpdate(nextProps, nextState) {
          if (!isEqual(this.state, nextState)) return true;
          const { data } = this.props;
          if (data === nextProps.data) return false;
          const oldModel = DateMatcherModel.deserialize(data);
      Severity: Major
      Found in src/apps/DateMatcherApplication.jsx and 1 other location - About 3 hrs to fix
      src/apps/DrawApplication.jsx on lines 58..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        static deserialize(str) {
          try {
            const obj = Yaml.load(str);
            const model = new DateMatcherModel();
            if (obj.candidates) model.candidates = obj.candidates;
      Severity: Major
      Found in src/apps/DateMatcherApplication.jsx and 2 other locations - About 3 hrs to fix
      src/apps/DrawApplication.jsx on lines 35..45
      src/apps/MeetingTimeApplication.jsx on lines 77..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

      DateMatcherApplication.propTypes = {
        data: PropTypes.string.isRequired,
        onEdit: PropTypes.func.isRequired,
        appContext: PropTypes.shape({}).isRequired,
      };
      Severity: Major
      Found in src/apps/DateMatcherApplication.jsx and 17 other locations - About 1 hr to fix
      src/apps/BookmarksApplication.jsx on lines 181..185
      src/apps/DateApplication.jsx on lines 78..82
      src/apps/DrawApplication.jsx on lines 149..153
      src/apps/ErrorApplication.jsx on lines 41..45
      src/apps/ExternalApplication.jsx on lines 66..70
      src/apps/HelloApplication.jsx on lines 38..42
      src/apps/KPTApplication.jsx on lines 142..146
      src/apps/KanbanApplication.jsx on lines 532..536
      src/apps/MandalaApplication.jsx on lines 92..96
      src/apps/MapApplication.jsx on lines 209..213
      src/apps/MeetingTimeApplication.jsx on lines 148..152
      src/apps/ReversiApplication.jsx on lines 129..133
      src/apps/VoteApplication.jsx on lines 107..111
      src/apps/VoteCryptoApplication.jsx on lines 154..158
      src/apps/VoteHelpfulApplication.jsx on lines 154..158
      src/apps/WeatherApplication.jsx on lines 111..115
      src/apps/YoutubeApplication.jsx on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status