FujitsuLaboratories/cattaz

View on GitHub
src/apps/MapApplication.jsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function componentDidMount has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  componentDidMount() {
    const { data } = this.props;
    const map = MapModel.deserialize(data);
    const doc = this.refIframe.current.contentWindow.document;
    doc.open();
Severity: Major
Found in src/apps/MapApplication.jsx - About 3 hrs to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      shouldComponentUpdate(nextProps) {
        const { data } = this.props;
        if (data === nextProps.data) return false;
        const oldModel = MapModel.deserialize(data);
        const newModel = MapModel.deserialize(nextProps.data);
    Severity: Major
    Found in src/apps/MapApplication.jsx and 7 other locations - About 2 hrs to fix
    src/apps/BookmarksApplication.jsx on lines 115..121
    src/apps/DateApplication.jsx on lines 40..46
    src/apps/KPTApplication.jsx on lines 63..69
    src/apps/KanbanApplication.jsx on lines 429..435
    src/apps/MandalaApplication.jsx on lines 45..51
    src/apps/MeetingTimeApplication.jsx on lines 97..103
    src/apps/ReversiApplication.jsx on lines 42..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

    MapApplication.propTypes = {
      data: PropTypes.string.isRequired,
      onEdit: PropTypes.func.isRequired,
      appContext: PropTypes.shape({}).isRequired,
    };
    Severity: Major
    Found in src/apps/MapApplication.jsx and 17 other locations - About 1 hr to fix
    src/apps/BookmarksApplication.jsx on lines 181..185
    src/apps/DateApplication.jsx on lines 78..82
    src/apps/DateMatcherApplication.jsx on lines 227..231
    src/apps/DrawApplication.jsx on lines 149..153
    src/apps/ErrorApplication.jsx on lines 41..45
    src/apps/ExternalApplication.jsx on lines 66..70
    src/apps/HelloApplication.jsx on lines 38..42
    src/apps/KPTApplication.jsx on lines 142..146
    src/apps/KanbanApplication.jsx on lines 532..536
    src/apps/MandalaApplication.jsx on lines 92..96
    src/apps/MeetingTimeApplication.jsx on lines 148..152
    src/apps/ReversiApplication.jsx on lines 129..133
    src/apps/VoteApplication.jsx on lines 107..111
    src/apps/VoteCryptoApplication.jsx on lines 154..158
    src/apps/VoteHelpfulApplication.jsx on lines 154..158
    src/apps/WeatherApplication.jsx on lines 111..115
    src/apps/YoutubeApplication.jsx on lines 45..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status