Sign upLogin

Futsch1/medTimer

View on GitHub
Star
app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method showNotification has 9 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

    public int showNotification(String remindTime, String medicineName, String amount,
                                String instructions, int reminderId, int reminderEventId,
                                Color color, ReminderNotificationChannelManager.Importance importance,
                                int iconId) {
Severity: Major
Found in app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java - About 1 hr to fix

    Method has 9 parameters, which is greater than 7 authorized.
    Wontfix

        public int showNotification(String remindTime, String medicineName, String amount,
    Severity: Major
    Found in app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java by sonar-java

    A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

    Noncompliant Code Example

    With a maximum number of 4 parameters:

    public void doSomething(int param1, int param2, int param3, String param4, long param5) {
...
}

    Compliant Solution

    public void doSomething(int param1, int param2, int param3, String param4) {
...
}

    Exceptions

    Methods annotated with Spring's @RequestMapping may have a lot of parameters, encapsulation being possible. Such methods are therefore ignored.

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            } else {
            builder.addAction(R.drawable.x_circle, context.getString(R.string.notification_skipped), pendingDismissed);
            builder.addAction(R.drawable.hourglass_split, context.getString(R.string.notification_snooze), pendingSnooze);
            builder.setDeleteIntent(pendingTaken);
        }
    Severity: Major
    Found in app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java and 2 other locations - About 50 mins to fix
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 105..109
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 101..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (dismissNotificationAction.equals("0")) {
            builder.addAction(R.drawable.check2_circle, context.getString(R.string.notification_taken), pendingTaken);
            builder.addAction(R.drawable.hourglass_split, context.getString(R.string.notification_snooze), pendingSnooze);
            builder.setDeleteIntent(pendingDismissed);
        } else if (dismissNotificationAction.equals("1")) {
    Severity: Major
    Found in app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java and 2 other locations - About 50 mins to fix
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 109..113
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 105..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            } else if (dismissNotificationAction.equals("1")) {
            builder.addAction(R.drawable.check2_circle, context.getString(R.string.notification_taken), pendingTaken);
            builder.addAction(R.drawable.x_circle, context.getString(R.string.notification_skipped), pendingDismissed);
            builder.setDeleteIntent(pendingSnooze);
        } else {
    Severity: Major
    Found in app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java and 2 other locations - About 50 mins to fix
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 109..113
    app/src/main/java/com/futsch1/medtimer/reminders/Notifications.java on lines 101..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status