GAKUEngine/gaku

View on GitHub
core/db/migrate/20131025073352_gaku_core.rb

Summary

Maintainability
F
4 days
Test Coverage

Method change has 547 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def change
    create_table :gaku_badge_types do |t|
      t.string   :name
      t.string   :code
      t.text     :description
Severity: Major
Found in core/db/migrate/20131025073352_gaku_core.rb - About 2 days to fix

    File 20131025073352_gaku_core.rb has 553 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'gaku/migrations'
    
    class GakuCore < ActiveRecord::Migration[4.2]
    
      include Gaku::Migrations
    Severity: Major
    Found in core/db/migrate/20131025073352_gaku_core.rb - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          create_table :gaku_external_school_records do |t|
            t.date     :beginning
            t.date     :ending
            t.string   :student_id_number
            t.integer  :absences
      Severity: Minor
      Found in core/db/migrate/20131025073352_gaku_core.rb and 1 other location - About 35 mins to fix
      core/db/migrate/20131025073352_gaku_core.rb on lines 185..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          create_table :gaku_exam_portions do |t|
            t.string   :name
            t.float    :max_score
            t.float    :weight
            t.integer  :problem_count
      Severity: Minor
      Found in core/db/migrate/20131025073352_gaku_core.rb and 1 other location - About 35 mins to fix
      core/db/migrate/20131025073352_gaku_core.rb on lines 244..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status