Sign upLogin

GAKUEngine/gaku_imex

View on GitHub
Star

Showing 11 of 11 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            students.each_with_index do |student_data, i|
              page.list("examinee_list").add_row do |row|
                row.item(:rank).value i + 1

                row.item(:examinee_number).value student_data[:student][:serial_id]
Severity: Major
Found in lib/exporters/exams/conference_document_sort_by_exam_total.rb and 1 other location - About 1 day to fix
lib/exporters/exams/conference_document_sort_by_examinee_number.rb on lines 63..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 317.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            students.each_with_index do |student_data, i|
              page.list("examinee_list").add_row do |row|
                row.item(:rank).value i + 1

                row.item(:examinee_number).value student_data[:student][:serial_id]
Severity: Major
Found in lib/exporters/exams/conference_document_sort_by_examinee_number.rb and 1 other location - About 1 day to fix
lib/exporters/exams/conference_document_sort_by_exam_total.rb on lines 63..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 317.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method generate has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.generate(data)
          # portion names --------
          #   numerical:
          #     試験：国語
          #     試験：数学
Severity: Major
Found in lib/exporters/exams/conference_document_sort_by_exam_total.rb - About 3 hrs to fix

    Method generate has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.generate(data)
          # portion names --------
          #   numerical:
          #     試験：国語
          #     試験：数学
    Severity: Major
    Found in lib/exporters/exams/conference_document_sort_by_examinee_number.rb - About 3 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                def self.get_added_total_score_students(data)
            new_students = []
            data[:students].map do |student|
              scores = student.exam_portion_scores.select {|score| score[:gradable_id] === data[:exam_session][:id]}
      Severity: Major
      Found in lib/exporters/exams/conference_document_sort_by_examinee_number.rb and 1 other location - About 2 hrs to fix
      lib/exporters/exams/conference_document_sort_by_exam_total.rb on lines 29..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                def self.get_added_total_score_students(data)
            new_students = []
            data[:students].map do |student|
              scores = student.exam_portion_scores.select {|score| score[:gradable_id] === data[:exam_session][:id]}
      Severity: Major
      Found in lib/exporters/exams/conference_document_sort_by_exam_total.rb and 1 other location - About 2 hrs to fix
      lib/exporters/exams/conference_document_sort_by_examinee_number.rb on lines 29..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method generate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.generate(data)
          # portion names --------
          #   numerical:
          #     試験：国語
          #     試験：数学
      Severity: Minor
      Found in lib/exporters/exams/conference_document_sort_by_examinee_number.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.generate(data)
          # portion names --------
          #   numerical:
          #     試験：国語
          #     試験：数学
      Severity: Minor
      Found in lib/exporters/exams/conference_document_sort_by_exam_total.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.generate(data)
          report = ThinReports::Report.new layout: File.join(Gaku::Imex::Engine.root,  'app', 'reports', 'result_roster.tlf')
          report.start_new_page do |page|
            page.item(:report_name).value data[:exam][:name]
            page.item(:date).value Date.today.to_s
      Severity: Minor
      Found in lib/exporters/exams/result_roster.rb - About 1 hr to fix

        Method generate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                def self.generate(data)
          report = ThinReports::Report.new layout: File.join(Gaku::Imex::Engine.root,  'app', 'reports', 'result_roster.tlf')
          report.start_new_page do |page|
            page.item(:report_name).value data[:exam][:name]
            page.item(:date).value Date.today.to_s
        Severity: Minor
        Found in lib/exporters/exams/result_roster.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def import
      cleanup_student_states

      enrollment_status_code = Gaku::EnrollmentStatus.where(code: 'enrolled', active: true, immutable: true)
                                                     .first_or_create!.try(:code)
        Severity: Minor
        Found in lib/gaku/importers/students/csv.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language